Skip to content

Conversation

kanelikki
Copy link
Contributor

Summary

On the Path.Join documentation, the backslash is not showing near:
" that use the Windows backslash"... on https://docs.microsoft.com/en-us/dotnet/api/system.io.path.join?view=netcore-3.1

https://docs.microsoft.com/en-us/dotnet/api/system.io.path.join?view=netcore-3.1

On the Path.Join documentation, the backslash isn't shown.
@dotnet-bot dotnet-bot added this to the June 2020 milestone Jun 2, 2020
@mairaw
Copy link
Contributor

mairaw commented Jun 3, 2020

This is a good change @rnielikki but that same pattern occurs a few more times in the file. Would you like to address them too? Otherwise, we can help.

@mairaw mairaw added the ✨ 1st-time dotnet-api-docs contributor! Indicates PRs from new contributors to the dotnet-api-docs repository label Jun 3, 2020
@kanelikki
Copy link
Contributor Author

I changed more of them, but I didn't touch inside <![CDATA[ ...>
Does the change needed there too?

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the occurrences look great on that page now. Thanks @rnielikki!

@mairaw mairaw merged commit 764ce99 into dotnet:master Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ 1st-time dotnet-api-docs contributor! Indicates PRs from new contributors to the dotnet-api-docs repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants