The 2nd batch patch for msdn url #4347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mairaw @BillWagner @TianqiZhang This is the 2nd Patch, please help to review it. |
|
Build with Error: A task was canceled. need reopen to re-run it. |
mairaw
requested changes
Jun 10, 2020
There was a problem hiding this comment.
Great changes @luyajun0205. Left a few comments to be addressed before merging.
Pay attention to the following bugs:
- Don't replace msdn links with different msdn links (the F# content still hasn't migrated)
- There are a couple of links that have a version extension that is being kept when the link is updated to docs, The version should be removed. The extension looks like this for example:
\(v=vs.85\).aspx
xml/System.Runtime.Remoting.Metadata.W3cXsd2001/SoapBase64Binary.xml
Outdated
Show resolved
Hide resolved
Co-authored-by: Maira Wenzel <mairaw@microsoft.com>
|
@mairaw @BillWagner this PR has been updated, please help review again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Describe your changes here.
Fixes #Issue_Number (if available)