Skip to content

SslStream - update documentation #4372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 18, 2020
Merged

SslStream - update documentation #4372

merged 8 commits into from
Jun 18, 2020

Conversation

aik-jahoda
Copy link
Contributor

Summary

Collect all changes from #3916 related to SslStream

@dotnet-bot dotnet-bot added this to the June 2020 milestone Jun 12, 2020
@carlossanlop carlossanlop mentioned this pull request Jun 12, 2020
Closed
@aik-jahoda
Copy link
Contributor Author

Doc preview: https://review.docs.microsoft.com/en-us/dotnet/api/system.net.security.sslstream?branch=pr-en-us-4372&view=netcore-3.1

@aik-jahoda aik-jahoda requested a review from ManickaP June 12, 2020 11:41
@aik-jahoda aik-jahoda marked this pull request as ready for review June 12, 2020 11:42
@aik-jahoda aik-jahoda requested a review from gewarren June 12, 2020 11:43
ManickaP
ManickaP reviewed Jun 12, 2020
View reviewed changes
Copy link
Member

@ManickaP ManickaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not expert here, so feel free to correct me on any of my comments.

aik-jahoda and others added 3 commits June 15, 2020 14:54
@aik-jahoda @ManickaP
Apply suggestions from code review
7029de2 
Co-authored-by: Marie Píchová <11718369+ManickaP@users.noreply.github.com>
Apply PR comments
b6351c9
Merge branch 'jajahoda/SslStream' of github.com:aik-jahoda/dotnet-api…
5fec3bd 
…-docs into jajahoda/SslStream
gewarren
gewarren reviewed Jun 16, 2020
View reviewed changes
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One build warning and a couple of grammatical suggestions.

@aik-jahoda @gewarren
Apply suggestions from code review
93dd4b7 
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
ManickaP
ManickaP approved these changes Jun 18, 2020
View reviewed changes
Copy link
Member

@ManickaP ManickaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aik-jahoda aik-jahoda merged commit d89c3c4 into dotnet:master Jun 18, 2020
@aik-jahoda aik-jahoda deleted the jajahoda/SslStream branch September 2, 2020 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gewarren gewarren gewarren left review comments

@ManickaP ManickaP ManickaP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
June 2020
Development

Successfully merging this pull request may close these issues.
4 participants
@aik-jahoda @ManickaP @gewarren @dotnet-bot