Skip to content

Fix bad period placements #4534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 17, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -283,8 +283,7 @@
<param name="services">The <see cref="T:Microsoft.Extensions.DependencyInjection.IServiceCollection" />.</param>
<param name="descriptor">The <see cref="T:Microsoft.Extensions.DependencyInjection.ServiceDescriptor" />.</param>
<summary>Adds a <see cref="T:Microsoft.Extensions.DependencyInjection.ServiceDescriptor" /> if an existing descriptor with the same
<see cref="P:Microsoft.Extensions.DependencyInjection.ServiceDescriptor.ServiceType" /> and an implementation that does not already exist
in <paramref name="services.." />.</summary>
<see cref="P:Microsoft.Extensions.DependencyInjection.ServiceDescriptor.ServiceType" /> and an implementation that does not already exist in <paramref name="services" />.</summary>
<remarks>Use <see cref="M:Microsoft.Extensions.DependencyInjection.Extensions.ServiceCollectionDescriptorExtensions.TryAddEnumerable(Microsoft.Extensions.DependencyInjection.IServiceCollection,Microsoft.Extensions.DependencyInjection.ServiceDescriptor)" /> when registering a service implementation of a
service type that
supports multiple registrations of the same service type. Using
Expand Down Expand Up @@ -325,7 +324,7 @@
<param name="descriptors">The <see cref="T:Microsoft.Extensions.DependencyInjection.ServiceDescriptor" />s.</param>
<summary>Adds the specified <see cref="T:Microsoft.Extensions.DependencyInjection.ServiceDescriptor" />s if an existing descriptor with the same
<see cref="P:Microsoft.Extensions.DependencyInjection.ServiceDescriptor.ServiceType" /> and an implementation that does not already exist
in <paramref name="services.." />.</summary>
in <paramref name="services" />.</summary>
<remarks>Use <see cref="M:Microsoft.Extensions.DependencyInjection.Extensions.ServiceCollectionDescriptorExtensions.TryAddEnumerable(Microsoft.Extensions.DependencyInjection.IServiceCollection,Microsoft.Extensions.DependencyInjection.ServiceDescriptor)" /> when registering a service
implementation of a service type that
supports multiple registrations of the same service type. Using
Expand Down
2 changes: 1 addition & 1 deletion xml/Microsoft.VisualBasic/Financial.xml
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@
]]></format>
</remarks>
<exception cref="T:System.ArgumentException">
<paramref name="Factor" /> &lt;= 0, <paramref name="Salvage" /> &lt; 0, <paramref name="Period" /> &lt;= 0, or <paramref name="Period" /> &gt; <paramref name="Life." /></exception>
<paramref name="Factor" /> &lt;= 0, <paramref name="Salvage" /> &lt; 0, <paramref name="Period" /> &lt;= 0, or <paramref name="Period" /> &gt; <paramref name="Life" />.</exception>
<altmember cref="M:Microsoft.VisualBasic.Financial.SLN(System.Double,System.Double,System.Double)" />
<altmember cref="M:Microsoft.VisualBasic.Financial.SYD(System.Double,System.Double,System.Double,System.Double)" />
<altmember cref="T:System.ArgumentException" />
Expand Down
6 changes: 3 additions & 3 deletions xml/System.Drawing/Image.xml
Original file line number Diff line number Diff line change
Expand Up @@ -1761,7 +1761,7 @@
]]></format>
</remarks>
<exception cref="T:System.ArgumentNullException">
<paramref name="filename" /> is <see langword="null." /></exception>
<paramref name="filename" /> is <see langword="null" />.</exception>
<exception cref="T:System.Runtime.InteropServices.ExternalException">The image was saved with the wrong image format.

-or-
Expand Down Expand Up @@ -1863,7 +1863,7 @@
]]></format>
</remarks>
<exception cref="T:System.ArgumentNullException">
<paramref name="filename" /> or <paramref name="format" /> is <see langword="null." /></exception>
<paramref name="filename" /> or <paramref name="format" /> is <see langword="null" />.</exception>
<exception cref="T:System.Runtime.InteropServices.ExternalException">The image was saved with the wrong image format.

-or-
Expand Down Expand Up @@ -1976,7 +1976,7 @@
]]></format>
</remarks>
<exception cref="T:System.ArgumentNullException">
<paramref name="filename" /> or <paramref name="encoder" /> is <see langword="null." /></exception>
<paramref name="filename" /> or <paramref name="encoder" /> is <see langword="null" />.</exception>
<exception cref="T:System.Runtime.InteropServices.ExternalException">The image was saved with the wrong image format.

-or-
Expand Down
2 changes: 1 addition & 1 deletion xml/System.Drawing/ImageFormatConverter.xml
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@
</remarks>
<exception cref="T:System.NotSupportedException">The conversion cannot be completed.</exception>
<exception cref="T:System.ArgumentNullException">
<paramref name="destinationType" /> is <see langword="null." /></exception>
<paramref name="destinationType" /> is <see langword="null" />.</exception>
</Docs>
</Member>
<Member MemberName="GetStandardValues">
Expand Down
2 changes: 1 addition & 1 deletion xml/System.IdentityModel.Claims/ClaimSet.xml
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@
<param name="comparer">The <see cref="T:System.Collections.Generic.IEqualityComparer`1" /> object used to make the comparison.</param>
<summary>Determines whether the <see cref="T:System.IdentityModel.Claims.ClaimSet" /> contains the specified <see cref="T:System.IdentityModel.Claims.Claim" />, by using the specified <see cref="T:System.Collections.Generic.IEqualityComparer`1" /> object.</summary>
<returns>
<see langword="true" /> if the specified claim is contained in the <see cref="T:System.IdentityModel.Claims.ClaimSet" />; otherwise <see langword="false." /></returns>
<see langword="true" /> if the specified claim is contained in the <see cref="T:System.IdentityModel.Claims.ClaimSet" />; otherwise <see langword="false" />.</returns>
<remarks>
<format type="text/markdown"><![CDATA[

Expand Down
4 changes: 2 additions & 2 deletions xml/System.Net.Mail/AlternateView.xml
Original file line number Diff line number Diff line change
Expand Up @@ -572,8 +572,8 @@
</Parameters>
<Docs>
<param name="content">A <see cref="T:System.String" /> that contains the content for this attachment.</param>
<param name="contentEncoding">An <see cref="T:System.Text.Encoding" />. This value can be <see langword="null." /></param>
<param name="encoding">An <see cref="T:System.Text.Encoding" />. This value can be <see langword="null." /></param>
<param name="contentEncoding">An <see cref="T:System.Text.Encoding" />. This value can be <see langword="null" />.</param>
<param name="encoding">An <see cref="T:System.Text.Encoding" />. This value can be <see langword="null" />.</param>
<param name="mediaType">The MIME media type of the content.</param>
<summary>Creates an <see cref="T:System.Net.Mail.AlternateView" /> of an email message using the content specified in a <see cref="T:System.String" />, the specified text encoding, and MIME media type of the content.</summary>
<returns>An <see cref="T:System.Net.Mail.AlternateView" /> object that represents an alternate view of an email message.</returns>
Expand Down
6 changes: 3 additions & 3 deletions xml/System.Net.PeerToPeer.Collaboration/Peer.xml
Original file line number Diff line number Diff line change
Expand Up @@ -511,7 +511,7 @@
]]></format>
</remarks>
<exception cref="T:System.ArgumentNullException">
<paramref name="userToken" /> is <see langword="null." /></exception>
<paramref name="userToken" /> is <see langword="null" />.</exception>
<exception cref="T:System.Net.PeerToPeer.PeerToPeerException">- An error occurred during the invitation process.

- The currently executing application is not registered with the collaboration infrastructure.</exception>
Expand Down Expand Up @@ -558,7 +558,7 @@
</remarks>
<exception cref="T:System.ArgumentException">The application is not registered with the collaboration infrastructure.</exception>
<exception cref="T:System.ArgumentNullException">
<paramref name="userToken" /> is <see langword="null." /></exception>
<paramref name="userToken" /> is <see langword="null" />.</exception>
<exception cref="T:System.ArgumentOutOfRangeException">
<paramref name="invitationData" /> is larger than 16,384 bytes.</exception>
<exception cref="T:System.Net.PeerToPeer.PeerToPeerException">- An error occurred during the invitation process.
Expand Down Expand Up @@ -611,7 +611,7 @@

]]></format>
</remarks>
<exception cref="T:System.ArgumentNullException">The <paramref name="userToken" /> parameter cannot be <see langword="null." /></exception>
<exception cref="T:System.ArgumentNullException">The <paramref name="userToken" /> parameter cannot be <see langword="null" />.</exception>
<exception cref="T:System.InvalidOperationException">An asynchronous invitation is not outstanding.</exception>
<altmember cref="M:System.Net.PeerToPeer.Collaboration.Peer.Invite" />
<altmember cref="P:System.Net.PeerToPeer.Collaboration.InviteCompletedEventArgs.InviteResponse" />
Expand Down
8 changes: 4 additions & 4 deletions xml/System.Net.PeerToPeer.Collaboration/PeerCollaboration.xml
Original file line number Diff line number Diff line change
Expand Up @@ -629,7 +629,7 @@

]]></format>
</remarks>
<exception cref="T:System.ArgumentException">- The <see cref="P:System.Net.PeerToPeer.Collaboration.PeerApplication.Path" /> property on the <see cref="T:System.Net.PeerToPeer.Collaboration.PeerApplication" /> object passed to <paramref name="application" /> is <see langword="null." />
<exception cref="T:System.ArgumentException">- The <see cref="P:System.Net.PeerToPeer.Collaboration.PeerApplication.Path" /> property on the <see cref="T:System.Net.PeerToPeer.Collaboration.PeerApplication" /> object passed to <paramref name="application" /> is <see langword="null" />.

- The peer application instance provided has the same globally unique <see cref="P:System.Net.PeerToPeer.Collaboration.PeerApplication.Id" /> as an application which is already registered. The existing registration must be unregistered before a new application can be registered with the provided identifier.</exception>
<exception cref="T:System.ArgumentNullException">The <paramref name="application" /> and <paramref name="type" /> parameters cannot be <see langword="null" />. Both parameters must be specified.</exception>
Expand Down Expand Up @@ -678,9 +678,9 @@
]]></format>
</remarks>
<exception cref="T:System.ArgumentException">Object already registered</exception>
<exception cref="T:System.ArgumentNullException">- <see cref="T:System.Net.PeerToPeer.Collaboration.PeerObject" /> cannot be <see langword="null." />
<exception cref="T:System.ArgumentNullException">- <see cref="T:System.Net.PeerToPeer.Collaboration.PeerObject" /> cannot be <see langword="null" />.

- <see cref="P:System.Net.PeerToPeer.Collaboration.PeerObject.Id" /> cannot be <see langword="null." /></exception>
- <see cref="P:System.Net.PeerToPeer.Collaboration.PeerObject.Id" /> cannot be <see langword="null" />.</exception>
<exception cref="T:System.Net.PeerToPeer.PeerToPeerException">The <see cref="M:System.Net.PeerToPeer.Collaboration.PeerCollaboration.SetObject(System.Net.PeerToPeer.Collaboration.PeerObject)" /> operation could not be completed.</exception>
<altmember cref="Overload:System.Net.PeerToPeer.Collaboration.PeerCollaboration.GetLocalRegisteredApplications" />
<altmember cref="M:System.Net.PeerToPeer.Collaboration.PeerCollaboration.GetLocalSetObjects" />
Expand Down Expand Up @@ -918,7 +918,7 @@
]]></format>
</remarks>
<exception cref="T:System.ArgumentException">The globally unique <see cref="P:System.Net.PeerToPeer.Collaboration.PeerApplication.Id" /> for the specified application does not exist or is empty.</exception>
<exception cref="T:System.ArgumentNullException">The <paramref name="application" /> or <paramref name="type" /> parameter is set to <see langword="null." /></exception>
<exception cref="T:System.ArgumentNullException">The <paramref name="application" /> or <paramref name="type" /> parameter is set to <see langword="null" />.</exception>
<exception cref="T:System.ArgumentOutOfRangeException">The <paramref name="type" /> parameter is not set to a known value in <see cref="T:System.Net.PeerToPeer.Collaboration.PeerApplicationRegistrationType" />.</exception>
<exception cref="T:System.Net.PeerToPeer.PeerToPeerException">The <see cref="M:System.Net.PeerToPeer.Collaboration.PeerCollaboration.UnregisterApplication(System.Net.PeerToPeer.Collaboration.PeerApplication,System.Net.PeerToPeer.Collaboration.PeerApplicationRegistrationType)" /> operation could not be completed.</exception>
<altmember cref="Overload:System.Net.PeerToPeer.Collaboration.PeerCollaboration.GetLocalRegisteredApplications" />
Expand Down
16 changes: 8 additions & 8 deletions xml/System.Net.PeerToPeer.Collaboration/PeerContact.xml
Original file line number Diff line number Diff line change
Expand Up @@ -427,7 +427,7 @@

]]></format>
</remarks>
<exception cref="T:System.ArgumentNullException">Parameter cannot be <see langword="null." /></exception>
<exception cref="T:System.ArgumentNullException">Parameter cannot be <see langword="null" />.</exception>
<exception cref="T:System.Net.PeerToPeer.PeerToPeerException">- Unable to complete <see cref="M:System.Net.PeerToPeer.Collaboration.PeerContact.FromXml(System.String)" /> operation

- Parameter is not a valid <see cref="M:System.Net.PeerToPeer.Collaboration.PeerCollaborationPermission.FromXml(System.Security.SecurityElement)" /> object.</exception>
Expand Down Expand Up @@ -1148,7 +1148,7 @@
<exception cref="T:System.ObjectDisposedException">The <see cref="T:System.Net.PeerToPeer.Collaboration.PeerEndPoint" /> object has been disposed.</exception>
<exception cref="T:System.Net.PeerToPeer.PeerToPeerException">- The <see cref="P:System.Net.PeerToPeer.Collaboration.PeerApplication.Id" /> for the current application does not exist or is empty.

- <see cref="T:System.Net.PeerToPeer.Collaboration.PeerEndPointCollection" /> cannot be <see langword="null." /></exception>
- <see cref="T:System.Net.PeerToPeer.Collaboration.PeerEndPointCollection" /> cannot be <see langword="null" />.</exception>
<block subset="none" type="usage">
<para>Additional overloads are defined on the <see cref="T:System.Net.PeerToPeer.Collaboration.Peer" /> class instead of the subclasses <see cref="T:System.Net.PeerToPeer.Collaboration.PeerContact" /> and <see cref="T:System.Net.PeerToPeer.Collaboration.PeerNearMe" />.

Expand Down Expand Up @@ -1197,11 +1197,11 @@

]]></format>
</remarks>
<exception cref="T:System.ArgumentException">- <paramref name="UserToken" /> cannot be <see langword="null." />
<exception cref="T:System.ArgumentException">- <paramref name="UserToken" /> cannot be <see langword="null" />.

- Endpoint in <paramref name="peerEndPoint" /> cannot be <see langword="null" />.</exception>
<exception cref="T:System.ArgumentNullException">
<paramref name="peerEndPoint" /> object cannot be <see langword="null." /></exception>
<paramref name="peerEndPoint" /> object cannot be <see langword="null" />.</exception>
<exception cref="T:System.ObjectDisposedException">The <see cref="T:System.Net.PeerToPeer.Collaboration.PeerEndPoint" /> object has been disposed.</exception>
<exception cref="T:System.Net.PeerToPeer.PeerToPeerException">The <see cref="T:System.Guid" /> for the current application does not exist or is empty.</exception>
<block subset="none" type="usage">
Expand Down Expand Up @@ -1260,11 +1260,11 @@
<exception cref="T:System.ArgumentException">
<paramref name="UserToken" /> cannot be <see langword="null" />.</exception>
<exception cref="T:System.ArgumentNullException">
<see cref="T:System.Net.PeerToPeer.Collaboration.PeerApplication" /> object cannot be <see langword="null." /></exception>
<see cref="T:System.Net.PeerToPeer.Collaboration.PeerApplication" /> object cannot be <see langword="null" />.</exception>
<exception cref="T:System.ObjectDisposedException">The <see cref="T:System.Net.PeerToPeer.Collaboration.PeerEndPoint" /> object has been disposed.</exception>
<exception cref="T:System.Net.PeerToPeer.PeerToPeerException">- The <see cref="T:System.Guid" /> for the current application does not exist or is empty.

- Endpoint collection is empty or <see langword="null." /></exception>
- Endpoint collection is empty or <see langword="null" />.</exception>
<block subset="none" type="usage">
<para>Additional overloads are defined on the <see cref="T:System.Net.PeerToPeer.Collaboration.Peer" /> class instead of the subclasses <see cref="T:System.Net.PeerToPeer.Collaboration.PeerContact" /> and <see cref="T:System.Net.PeerToPeer.Collaboration.PeerNearMe" />.

Expand Down Expand Up @@ -1323,7 +1323,7 @@

- Endpoint specified by <paramref name="peerEndPoint" /> cannot be <see langword="null" />.</exception>
<exception cref="T:System.ArgumentNullException">
<see cref="T:System.Net.PeerToPeer.Collaboration.PeerApplication" /> and <see cref="T:System.Net.PeerToPeer.Collaboration.PeerEndPoint" /> objects cannot be <see langword="null." /></exception>
<see cref="T:System.Net.PeerToPeer.Collaboration.PeerApplication" /> and <see cref="T:System.Net.PeerToPeer.Collaboration.PeerEndPoint" /> objects cannot be <see langword="null" />.</exception>
<exception cref="T:System.ObjectDisposedException">The <see cref="T:System.Net.PeerToPeer.Collaboration.PeerEndPoint" /> object has been disposed.</exception>
<exception cref="T:System.Net.PeerToPeer.PeerToPeerException">The <see cref="P:System.Net.PeerToPeer.Collaboration.PeerApplication.Id" /> for the current application does not exist or is empty.</exception>
<block subset="none" type="usage">
Expand Down Expand Up @@ -1811,7 +1811,7 @@
]]></format>
</remarks>
<exception cref="T:System.ArgumentNullException">
<paramref name="UserToken" /> cannot be <see langword="null." /></exception>
<paramref name="UserToken" /> cannot be <see langword="null" />.</exception>
<exception cref="T:System.InvalidOperationException">The calling peer is not signed in to People Near Me.</exception>
<exception cref="T:System.ObjectDisposedException">The <see cref="T:System.Net.PeerToPeer.Collaboration.PeerContact" /> object has been disposed.</exception>
<exception cref="T:System.Net.PeerToPeer.PeerToPeerException">Duplicate <see cref="M:System.Net.PeerToPeer.Collaboration.PeerContact.SubscribeAsync(System.Object)" /> identifier.</exception>
Expand Down
2 changes: 1 addition & 1 deletion xml/System.Net.PeerToPeer/CloudCollection.xml
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@

]]></format>
</remarks>
<exception cref="T:System.ArgumentNullException">The <see cref="T:System.Net.PeerToPeer.Cloud" /> provided cannot be <see langword="null." /></exception>
<exception cref="T:System.ArgumentNullException">The <see cref="T:System.Net.PeerToPeer.Cloud" /> provided cannot be <see langword="null" />.</exception>
<altmember cref="T:System.Net.PeerToPeer.CloudCollection" />
</Docs>
</Member>
Expand Down
4 changes: 2 additions & 2 deletions xml/System.Net.PeerToPeer/PeerNameRecord.xml
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@
]]></format>
</remarks>
<exception cref="T:System.ArgumentException">The comment to set is either larger than 39 Unicode characters or less than one character.</exception>
<exception cref="T:System.ArgumentNullException">The comment to set is <see langword="null." /></exception>
<exception cref="T:System.ArgumentNullException">The comment to set is <see langword="null" />.</exception>
</Docs>
</Member>
<Member MemberName="Data">
Expand Down Expand Up @@ -159,7 +159,7 @@
]]></format>
</remarks>
<exception cref="T:System.ArgumentException">The length of the binary data array to set is either greater than 4096 or less than 1.</exception>
<exception cref="T:System.ArgumentNullException">The data to set is <see langword="null." /></exception>
<exception cref="T:System.ArgumentNullException">The data to set is <see langword="null" />.</exception>
</Docs>
</Member>
<Member MemberName="EndPointCollection">
Expand Down
Loading