Add notes to not-recommended algorithm classes #4538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartonjs
reviewed
Jul 21, 2020
| Valid key sizes range from 512 to 3,072 bits, in increments of 64. We recommend that a minimum size of 2,048 bits be used for all keys. | ||
| > [!IMPORTANT] | ||
| > Newer asymmetric algorithms are available. Consider using the <xref:System.Security.Cryptography.RSA> class or the <xref:System.Security.Cryptography.ECDsa> class instead of the <xref:System.Security.Cryptography.DSA> class. Use <xref:System.Security.Cryptography.DSA> only for compatibility with legacy applications and data. |
There was a problem hiding this comment.
RSA is from 1977 and DSA is from 1991. RSA just had better staying power.
So perhaps "Better" instead of "Newer"? Or "The creators of the DSA algorithm have withdrawn their support for it."?
|
Just the one semantic issue, but its resolution needs to be copied to all of the DSA types. |
bartonjs
approved these changes
Jul 22, 2020
eiriktsarpalis
added
the
area-System.Security
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/docs#10202
Most of the affected classes already had the needed warnings. This PR just propagates those notes to derived and related classes and in some cases moves warning text into a note box.