-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Replace MD5 and SHA1 #4542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace MD5 and SHA1 #4542
Changes from all commits
fb48184
47c6ee7
a4cdae4
003ea2c
9e7fc88
4611633
ac48b88
5abb1ba
45ab38c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -67,8 +67,8 @@ public static void Main() | |
myAssemblyName.CodeBase = Directory.GetCurrentDirectory(); | ||
// Set the culture information of the assembly to 'English-American'. | ||
myAssemblyName.CultureInfo = new CultureInfo("en-US"); | ||
// Set the hash algoritm to 'SHA1'. | ||
myAssemblyName.HashAlgorithm = AssemblyHashAlgorithm.SHA1; | ||
// Set the hash algorithm to 'SHA256'. | ||
myAssemblyName.HashAlgorithm = AssemblyHashAlgorithm.SHA256; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Another triplet of AssemblyName.HashAlgorithm being updated. It might work, I just know that some parts of this system are effectively limited to MD5 and SHA1... and I don't know if this is one of them or not. (We could, of course, update them, and if we get feedback it doesn't work, then change them back) |
||
myAssemblyName.Name = "MyAssembly"; | ||
myAssemblyName.Version = new Version("1.0.0.2001"); | ||
MakeAssembly(myAssemblyName, "MyAssembly.exe"); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know that SHA256 actually works here.