Skip to content

Conversation

@mairaw mairaw self-requested a review July 21, 2020 22:16
@mairaw mairaw added the 👩‍💻 .NET Interactive These issues relate to using .NET Interactive in docs label Jul 21, 2020
@mairaw
Copy link
Contributor

mairaw commented Jul 25, 2020

Thanks @v-mepa. I made some of the fixes to the PR directly. There's one though that seems like a platform issue., I'll see if my last commit fixes the issue, otherwise we might have to open a bug for the eng team and remove that API from this PR (system.uri.isunc).

@v-mepa
Copy link
Contributor Author

v-mepa commented Jul 27, 2020

Thank you @mairaw for the fixes :)

@mairaw mairaw closed this Jul 27, 2020
@mairaw mairaw reopened this Jul 27, 2020
@mairaw
Copy link
Contributor

mairaw commented Jul 27, 2020

Weird error message. Trying a new build.

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looking good now!

@mairaw mairaw merged commit f986185 into dotnet:master Jul 27, 2020
@v-mepa v-mepa deleted the add_try_dotnet_to_batch_16a branch July 27, 2020 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👩‍💻 .NET Interactive These issues relate to using .NET Interactive in docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants