Skip to content

Highlight that the link to unsafe-escaping shows why it is unsafe. #4561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2020
Merged

Highlight that the link to unsafe-escaping shows why it is unsafe. #4561

merged 1 commit into from
Jul 22, 2020
+1 −1

Conversation

ahsonkhan
Copy link
Contributor

@tdykstra, let me know what you think about adding this wording.

@ahsonkhan ahsonkhan requested a review from tdykstra July 22, 2020 20:59
@dotnet-bot dotnet-bot added this to the July 2020 milestone Jul 22, 2020
tdykstra
tdykstra approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this addition makes sense.

@ahsonkhan ahsonkhan merged commit a19b9d9 into master Jul 22, 2020
@ahsonkhan ahsonkhan deleted the ahsonkhan-patch-1 branch July 22, 2020 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdykstra tdykstra tdykstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
July 2020
Development

Successfully merging this pull request may close these issues.
3 participants
@ahsonkhan @tdykstra @dotnet-bot