Skip to content

Batch 18 - Sample fixes for .NET Interactive #4664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2020

Conversation

mairaw
Copy link
Contributor

@mairaw mairaw commented Aug 12, 2020

Fixes output messages and removes Console.Clear call since it's not supported on .NET Interactive

@mairaw mairaw added the 👩‍💻 .NET Interactive These issues relate to using .NET Interactive in docs label Aug 12, 2020
@mairaw mairaw requested a review from a team August 13, 2020 18:47
@mairaw
Copy link
Contributor Author

mairaw commented Aug 14, 2020

@BillWagner @gewarren can I get this one reviewed? PR #4662 depends on this.

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @mairaw

I'll :shipit: now.

@BillWagner BillWagner merged commit a75c501 into dotnet:master Aug 14, 2020
@mairaw mairaw deleted the batch18-fixes branch August 14, 2020 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👩‍💻 .NET Interactive These issues relate to using .NET Interactive in docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants