Skip to content

Conversation

heshamamin
Copy link
Contributor

Fix the description of returned Task from RunConsoleAsync. It completes upon token cancellation or application shutdown.

Fix description of returned Task from RunConsoleAsync.
@opbld30
Copy link

opbld30 commented Aug 15, 2020

Docs Build status updates of commit 2604f94:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/Microsoft.Extensions.Hosting/HostingHostBuilderExtensions.xml ⚠️Warning View Details

xml/Microsoft.Extensions.Hosting/HostingHostBuilderExtensions.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.Extensions.Hosting.Internal.ConsoleLifetime'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.Extensions.Hosting.Internal.ConsoleLifetime'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@heshamamin Thanks for fixing this. I just had one suggestion to improve it further.

heshamamin and others added 2 commits September 5, 2020 16:48
replace token with console

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
replace token with console

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@opbld31
Copy link

opbld31 commented Sep 5, 2020

Docs Build status updates of commit b34183b:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/Microsoft.Extensions.Hosting/HostingHostBuilderExtensions.xml ⚠️Warning View Details

xml/Microsoft.Extensions.Hosting/HostingHostBuilderExtensions.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.Extensions.Hosting.Internal.ConsoleLifetime'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.Extensions.Hosting.Internal.ConsoleLifetime'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@opbld33
Copy link

opbld33 commented Sep 5, 2020

Docs Build status updates of commit 119fb96:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/Microsoft.Extensions.Hosting/HostingHostBuilderExtensions.xml ⚠️Warning View Details

xml/Microsoft.Extensions.Hosting/HostingHostBuilderExtensions.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.Extensions.Hosting.Internal.ConsoleLifetime'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.Extensions.Hosting.Internal.ConsoleLifetime'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@gewarren gewarren merged commit ab00134 into dotnet:master Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants