Skip to content

.NET Interactive; Add try dotnet to batch 19c #4712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 1, 2020
Merged

.NET Interactive; Add try dotnet to batch 19c #4712

merged 4 commits into from
Sep 1, 2020

Conversation

v-mepa
Copy link
Contributor

@v-mepa v-mepa commented Aug 21, 2020

fyi @mairaw

Add try dotnet to batch 19c

URL Try .NET Status Comments
https://docs.microsoft.com/en-us/dotnet/api/system.globalization.numberformatinfo Batch 19 Sample 2, 5, 6, 9, 10, 11, 12, 13, 14,  15. Other samples are culture dependent. Fix sample 15 output.
https://docs.microsoft.com/en-us/dotnet/api/system.exception.-ctor Batch 19 Except sample 3 - It uses APIs not supported on Try .NET

@opbld31
Copy link

opbld31 commented Aug 21, 2020

Docs Build status updates of commit ba7d7f9:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
xml/System.Reflection.Emit/EnumBuilder.xml ❌Error Details
xml/System.Reflection.Emit/GenericTypeParameterBuilder.xml ❌Error Details
xml/System.Reflection.Emit/TypeBuilder.xml ❌Error Details
xml/System.Security.Cryptography/SHA256Managed.xml ❌Error Details
xml/System.Security.Cryptography/SHA1Managed.xml ❌Error Details
xml/System.Security.Cryptography/SHA512Managed.xml ❌Error Details
xml/System.Security.Cryptography/RNGCryptoServiceProvider.xml ❌Error Details
xml/System.Security.Cryptography/SHA384Managed.xml ❌Error Details
xml/System.Transactions.Configuration/MachineSettingsSection.xml ❌Error Details
xml/System.Transactions.Configuration/DefaultSettingsSection.xml ❌Error Details

xml/System.Reflection.Emit/EnumBuilder.xml

  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.

xml/System.Reflection.Emit/GenericTypeParameterBuilder.xml

  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.

xml/System.Reflection.Emit/TypeBuilder.xml

  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.

xml/System.Security.Cryptography/SHA256Managed.xml

  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.

xml/System.Security.Cryptography/SHA1Managed.xml

  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.

xml/System.Security.Cryptography/SHA512Managed.xml

  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.

xml/System.Security.Cryptography/RNGCryptoServiceProvider.xml

  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.

xml/System.Security.Cryptography/SHA384Managed.xml

  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.

xml/System.Transactions.Configuration/MachineSettingsSection.xml

  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.

xml/System.Transactions.Configuration/DefaultSettingsSection.xml

  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.
  • Line 0, Column 0: [Error-array-length-invalid] Array 'monikers' length should be >= 1.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@mairaw mairaw self-requested a review August 21, 2020 22:18
@mairaw mairaw added the 👩‍💻 .NET Interactive These issues relate to using .NET Interactive in docs label Aug 21, 2020
@BillWagner
Copy link
Member

closing and reopening to trigger a new build. The issue noted above is fixed.

@BillWagner BillWagner closed this Aug 25, 2020
@BillWagner BillWagner reopened this Aug 25, 2020
@opbld30
Copy link

opbld30 commented Aug 25, 2020

Docs Build status updates of commit ba7d7f9:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Globalization/NumberFormatInfo.xml ✅Succeeded View
xml/System/Exception.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

mairaw
mairaw approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks @v-mepa!

@mairaw mairaw merged commit 3e68fa0 into dotnet:master Sep 1, 2020
@v-mepa v-mepa deleted the add_try_dotnet_to_batch_19c branch September 1, 2020 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mairaw mairaw mairaw approved these changes

Assignees
No one assigned
Labels
👩‍💻 .NET Interactive These issues relate to using .NET Interactive in docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@v-mepa @opbld31 @BillWagner @opbld30 @mairaw