Skip to content

Conversation

Maoni0
Copy link
Member

@Maoni0 Maoni0 commented Aug 26, 2020

Summary

Fill in info for some GC APIs' returns.

@Maoni0
Copy link
Member Author

Maoni0 commented Aug 26, 2020

@carlossanlop

@opbld32
Copy link

opbld32 commented Aug 26, 2020

Docs Build status updates of commit 534a3c0:

✅ Validation status: passed

File Status Preview URL Details
xml/System/GC.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@@ -250,7 +250,7 @@ If pinned is set to `true`, `T` must not be a reference type or a type that cont
<param name="length">Specifies the length of the array.</param>
<param name="pinned">Specifies whether the allocated array must be pinned.</param>
<summary>Allocates an array while skipping zero-initialization, if possible.</summary>
<returns>To be added.</returns>
<returns>An array object with uninitialized memory except if it contains references or if it's too small for unpinned.</returns>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

except if it contains references or if it's too small for unpinned.

Does this mean it will throw an exception for those cases? If yes, which exception? Exceptions need to be added as extra xml fields, right below <remarks>. I can help with that if necessary.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh yes that's a great thing to mention. for those cases it would simply allocated a normal array, ie, just do new T[length]. no exception is thrown.

@carlossanlop carlossanlop merged commit 08f1555 into dotnet:master Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants