Skip to content

Do not specify units in KeySizes properties #4745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 1, 2020
Merged

Do not specify units in KeySizes properties #4745

merged 1 commit into from
Sep 1, 2020

Conversation

krwq
Copy link
Member

@krwq krwq commented Aug 31, 2020

Fixes: dotnet/runtime#1910

Summary

Do not specify units in KeySizes properties.

Most of the usages in the runtime of KeySizes use bits but AesCcm/AesGcm use bytes.

I made sure units (bytes/bits) are mentioned on all usages of KeySizes (LegalKeySizes specifically)

cc: @vcsjones

@krwq krwq requested a review from bartonjs August 31, 2020 08:07
@opbld31
Copy link

opbld31 commented Aug 31, 2020

Docs Build status updates of commit f598383:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/System.Runtime.CompilerServices/AsyncIteratorStateMachineAttribute.xml ⚠️Warning View Details
xml/System.Runtime.CompilerServices/EnumeratorCancellationAttribute.xml ⚠️Warning View Details
xml/Microsoft.Build.Construction/ProjectInSolution.xml ⚠️Warning View Details
xml/Microsoft.Activities.Build.Validation/DeferredValidationTask.xml ⚠️Warning View Details
xml/Microsoft.Activities.Build/WorkflowBuildMessageTask.xml ⚠️Warning View Details
xml/Microsoft.Build.BuildEngine/ToolsetCollection.xml ⚠️Warning View Details
xml/Microsoft.Build.Construction/SolutionConfigurationInSolution.xml ⚠️Warning View Details
xml/Microsoft.Build.Construction/ProjectConfigurationInSolution.xml ⚠️Warning View Details
xml/Microsoft.Activities.Build.Validation/ReportDeferredValidationErrorsTask.xml ⚠️Warning View Details
xml/Microsoft.Build.Construction/SolutionFile.xml ⚠️Warning View Details
xml/Microsoft.Build.Construction/ProjectSdkElement.xml ⚠️Warning View Details
xml/Microsoft.Build.Definition/ProjectOptions.xml ⚠️Warning View Details
xml/Microsoft.Build.Evaluation/ProvenanceResult.xml ⚠️Warning View Details
xml/Microsoft.Build.Evaluation/Provenance.xml ⚠️Warning View Details
xml/Microsoft.Build.Evaluation/NewProjectFileOptions.xml ⚠️Warning View Details
xml/Microsoft.Build.Evaluation/GlobResult.xml ⚠️Warning View Details
xml/Microsoft.Build.Evaluation.Context/EvaluationContext.xml ⚠️Warning View Details
xml/Microsoft.Build.Framework/MetaprojectGeneratedEventArgs.xml ⚠️Warning View Details
xml/Microsoft.Build.Framework/PropertyInitialValueSetEventArgs.xml ⚠️Warning View Details
xml/Microsoft.Build.Framework/UninitializedPropertyReadEventArgs.xml ⚠️Warning View Details
xml/Microsoft.Build.Execution/RequestedProjectState.xml ⚠️Warning View Details
xml/Microsoft.Build.Logging/BuildEventArgsReader.xml ⚠️Warning View Details
xml/Microsoft.Build.Framework/SdkResolverContext.xml ⚠️Warning View Details
xml/Microsoft.Build.Globbing/MSBuildGlob.xml ⚠️Warning View Details
xml/Microsoft.Build.Framework/PropertyReassignmentEventArgs.xml ⚠️Warning View Details
xml/Microsoft.Build.Logging/ProfilerLogger.xml ⚠️Warning View Details
xml/Microsoft.Build.ObjectModelRemoting/ProjectElementLink.xml ⚠️Warning View Details
xml/Microsoft.Build.Graph/GraphBuildSubmission.xml ⚠️Warning View Details
xml/Microsoft.Build.Globbing/CompositeGlob.xml ⚠️Warning View Details
xml/Microsoft.Build.ObjectModelRemoting/ProjectItemElementLink.xml ⚠️Warning View Details
xml/Microsoft.Build.Graph/ProjectGraph.xml ⚠️Warning View Details
xml/Microsoft.Build.Framework/EnvironmentVariableReadEventArgs.xml ⚠️Warning View Details
xml/Microsoft.Build.Framework/SdkReference.xml ⚠️Warning View Details
xml/Microsoft.Build.Framework/ProjectEvaluationFinishedEventArgs.xml ⚠️Warning View Details
xml/Microsoft.Build.Graph/GraphBuildResult.xml ⚠️Warning View Details
xml/Microsoft.Build.Framework/ProjectImportedEventArgs.xml ⚠️Warning View Details
xml/Microsoft.Build.Graph/GraphBuildRequestData.xml ⚠️Warning View Details
xml/Microsoft.Build.Logging/BinaryLogReplayEventSource.xml ⚠️Warning View Details
xml/Microsoft.Build.Globbing/MSBuildGlobWithGaps.xml ⚠️Warning View Details
xml/Microsoft.Build.ObjectModelRemoting/ProjectItemGroupElementLink.xml ⚠️Warning View Details
xml/Microsoft.Build.Graph/ProjectGraphNode.xml ⚠️Warning View Details
xml/Microsoft.Build.ObjectModelRemoting/ProjectPropertyElementLink.xml ⚠️Warning View Details
xml/Microsoft.Build.ObjectModelRemoting/ProjectMetadataLink.xml ⚠️Warning View Details
xml/Microsoft.Build.Framework.Profiler/EvaluationLocation.xml ⚠️Warning View Details
xml/Microsoft.Build.ObjectModelRemoting/ProjectWhenElementLink.xml ⚠️Warning View Details
xml/Microsoft.Build.Framework/SdkLogger.xml ⚠️Warning View Details
xml/Microsoft.Build.ObjectModelRemoting/ProjectItemDefinitionLink.xml ⚠️Warning View Details
xml/Microsoft.Build.Logging/BinaryLogger.xml ⚠️Warning View Details
xml/Microsoft.Build.Tasks/CreateTemporaryVCProject.xml ⚠️Warning View Details
xml/Microsoft.Build.ObjectModelRemoting/ProjectOnErrorElementLink.xml ⚠️Warning View Details

This comment lists only the first 50 files in the pull request.

xml/System.Runtime.CompilerServices/AsyncIteratorStateMachineAttribute.xml

  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Runtime.CompilerServices.AsyncIteratorStateMachineAttribute's moniker dotnet-plat-ext-3.0 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Runtime.CompilerServices.AsyncIteratorStateMachineAttribute's moniker dotnet-plat-ext-3.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Runtime.CompilerServices.AsyncIteratorStateMachineAttribute's moniker dotnet-plat-ext-5.0 can't match any assembly.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Attribute.System#Runtime#InteropServices#_Attribute#GetIDsOfNames(System.Guid@,System.IntPtr,System.UInt32,System.UInt32,System.IntPtr)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Attribute.System#Runtime#InteropServices#_Attribute#GetTypeInfo(System.UInt32,System.UInt32,System.IntPtr)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Attribute.System#Runtime#InteropServices#_Attribute#GetTypeInfoCount(System.UInt32@)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Attribute.System#Runtime#InteropServices#_Attribute#Invoke(System.UInt32,System.Guid@,System.UInt32,System.Int16,System.IntPtr,System.IntPtr,System.IntPtr,System.IntPtr)'.

xml/System.Runtime.CompilerServices/EnumeratorCancellationAttribute.xml

  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Runtime.CompilerServices.EnumeratorCancellationAttribute's moniker dotnet-plat-ext-3.0 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Runtime.CompilerServices.EnumeratorCancellationAttribute's moniker dotnet-plat-ext-3.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Runtime.CompilerServices.EnumeratorCancellationAttribute's moniker dotnet-plat-ext-5.0 can't match any assembly.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Attribute.System#Runtime#InteropServices#_Attribute#GetIDsOfNames(System.Guid@,System.IntPtr,System.UInt32,System.UInt32,System.IntPtr)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Attribute.System#Runtime#InteropServices#_Attribute#GetTypeInfo(System.UInt32,System.UInt32,System.IntPtr)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Attribute.System#Runtime#InteropServices#_Attribute#GetTypeInfoCount(System.UInt32@)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Attribute.System#Runtime#InteropServices#_Attribute#Invoke(System.UInt32,System.Guid@,System.UInt32,System.Int16,System.IntPtr,System.IntPtr,System.IntPtr,System.IntPtr)'.

xml/Microsoft.Build.Construction/ProjectInSolution.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.Equals(System.Object)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetHashCode'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetType'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.MemberwiseClone'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.ToString'.

xml/Microsoft.Activities.Build.Validation/DeferredValidationTask.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.Build.Utilities.Task.BuildEngine5'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.Build.Utilities.Task.BuildEngine6'.

xml/Microsoft.Activities.Build/WorkflowBuildMessageTask.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.Build.Utilities.Task.BuildEngine5'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.Build.Utilities.Task.BuildEngine6'.

xml/Microsoft.Build.BuildEngine/ToolsetCollection.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Linq.Enumerable.SkipLast``1(System.Collections.Generic.IEnumerable{``0},System.Int32)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Linq.Enumerable.TakeLast``1(System.Collections.Generic.IEnumerable{``0},System.Int32)'.

xml/Microsoft.Build.Construction/SolutionConfigurationInSolution.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.Equals(System.Object)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetHashCode'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetType'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.MemberwiseClone'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.ToString'.

xml/Microsoft.Build.Construction/ProjectConfigurationInSolution.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.Equals(System.Object)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetHashCode'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetType'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.MemberwiseClone'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.ToString'.

xml/Microsoft.Activities.Build.Validation/ReportDeferredValidationErrorsTask.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.Build.Utilities.Task.BuildEngine5'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.Build.Utilities.Task.BuildEngine6'.

xml/Microsoft.Build.Construction/SolutionFile.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.Equals(System.Object)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetHashCode'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetType'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.MemberwiseClone'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.ToString'.

xml/Microsoft.Build.Construction/ProjectSdkElement.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.Equals(System.Object)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetHashCode'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetType'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.MemberwiseClone'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.ToString'.

xml/Microsoft.Build.Definition/ProjectOptions.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.Equals(System.Object)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetHashCode'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetType'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.MemberwiseClone'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.ToString'.

xml/Microsoft.Build.Evaluation/ProvenanceResult.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.Equals(System.Object)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetHashCode'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetType'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.MemberwiseClone'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.ToString'.

xml/Microsoft.Build.Evaluation/Provenance.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.FlagsAttribute'.

xml/Microsoft.Build.Evaluation/NewProjectFileOptions.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.FlagsAttribute'.

xml/Microsoft.Build.Evaluation/GlobResult.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.Equals(System.Object)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetHashCode'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetType'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.MemberwiseClone'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.ToString'.

xml/Microsoft.Build.Evaluation.Context/EvaluationContext.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.Equals(System.Object)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetHashCode'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetType'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.MemberwiseClone'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.ToString'.

xml/Microsoft.Build.Framework/MetaprojectGeneratedEventArgs.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.Equals(System.Object)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetHashCode'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetType'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.MemberwiseClone'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.ToString'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.SerializableAttribute'.

xml/Microsoft.Build.Framework/PropertyInitialValueSetEventArgs.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.Equals(System.Object)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetHashCode'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetType'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.MemberwiseClone'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.ToString'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.SerializableAttribute'.

xml/Microsoft.Build.Framework/UninitializedPropertyReadEventArgs.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.Equals(System.Object)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetHashCode'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetType'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.MemberwiseClone'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.ToString'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.SerializableAttribute'.

xml/Microsoft.Build.Execution/RequestedProjectState.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.Equals(System.Object)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetHashCode'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetType'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.MemberwiseClone'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.ToString'.

xml/Microsoft.Build.Logging/BuildEventArgsReader.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.Equals(System.Object)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetHashCode'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetType'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.MemberwiseClone'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.ToString'.

xml/Microsoft.Build.Framework/SdkResolverContext.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.Equals(System.Object)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetHashCode'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetType'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.MemberwiseClone'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.ToString'.

xml/Microsoft.Build.Globbing/MSBuildGlob.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.Equals(System.Object)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetHashCode'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetType'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.MemberwiseClone'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.ToString'.

xml/Microsoft.Build.Framework/PropertyReassignmentEventArgs.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.Equals(System.Object)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetHashCode'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetType'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.MemberwiseClone'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.ToString'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.SerializableAttribute'.

xml/Microsoft.Build.Logging/ProfilerLogger.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.Equals(System.Object)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetHashCode'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetType'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.MemberwiseClone'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.ToString'.

xml/Microsoft.Build.ObjectModelRemoting/ProjectElementLink.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.Build.Construction.ProjectElement.ExpressedAsAttribute'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.Equals(System.Object)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetHashCode'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetType'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.MemberwiseClone'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.ToString'.

xml/Microsoft.Build.Graph/GraphBuildSubmission.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.Equals(System.Object)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetHashCode'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetType'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.MemberwiseClone'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.ToString'.

xml/Microsoft.Build.Globbing/CompositeGlob.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.Equals(System.Object)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetHashCode'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetType'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.MemberwiseClone'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.ToString'.

xml/Microsoft.Build.ObjectModelRemoting/ProjectItemElementLink.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.Equals(System.Object)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetHashCode'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetType'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.MemberwiseClone'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.ToString'.

xml/Microsoft.Build.Graph/ProjectGraph.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.Build.BackEnd.CircularDependencyException'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.Equals(System.Object)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetHashCode'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetType'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.MemberwiseClone'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.ToString'.

xml/Microsoft.Build.Framework/EnvironmentVariableReadEventArgs.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.Equals(System.Object)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetHashCode'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetType'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.MemberwiseClone'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.ToString'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.SerializableAttribute'.

xml/Microsoft.Build.Framework/SdkReference.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetType'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.MemberwiseClone'.

xml/Microsoft.Build.Framework/ProjectEvaluationFinishedEventArgs.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.Equals(System.Object)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetHashCode'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetType'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.MemberwiseClone'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.ToString'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.SerializableAttribute'.

xml/Microsoft.Build.Graph/GraphBuildResult.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.Equals(System.Object)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetHashCode'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetType'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.MemberwiseClone'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.ToString'.

xml/Microsoft.Build.Framework/ProjectImportedEventArgs.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.Equals(System.Object)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetHashCode'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetType'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.MemberwiseClone'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.ToString'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.SerializableAttribute'.

xml/Microsoft.Build.Graph/GraphBuildRequestData.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.Equals(System.Object)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetHashCode'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetType'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.MemberwiseClone'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.ToString'.

xml/Microsoft.Build.Logging/BinaryLogReplayEventSource.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.Equals(System.Object)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetHashCode'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetType'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.MemberwiseClone'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.ToString'.

xml/Microsoft.Build.Globbing/MSBuildGlobWithGaps.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.Equals(System.Object)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetHashCode'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetType'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.MemberwiseClone'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.ToString'.

xml/Microsoft.Build.ObjectModelRemoting/ProjectItemGroupElementLink.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.Equals(System.Object)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetHashCode'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetType'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.MemberwiseClone'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.ToString'.

xml/Microsoft.Build.Graph/ProjectGraphNode.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.Equals(System.Object)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetHashCode'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetType'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.MemberwiseClone'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.ToString'.

xml/Microsoft.Build.ObjectModelRemoting/ProjectPropertyElementLink.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.Equals(System.Object)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetHashCode'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetType'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.MemberwiseClone'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.ToString'.

xml/Microsoft.Build.ObjectModelRemoting/ProjectMetadataLink.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.Build.Evaluation.ProjectMetadata.EvaluatedValueEscaped'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.Equals(System.Object)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetHashCode'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetType'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.MemberwiseClone'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.ToString'.

xml/Microsoft.Build.Framework.Profiler/EvaluationLocation.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.SerializableAttribute'.

xml/Microsoft.Build.ObjectModelRemoting/ProjectWhenElementLink.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.Equals(System.Object)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetHashCode'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetType'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.MemberwiseClone'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.ToString'.

xml/Microsoft.Build.Framework/SdkLogger.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.Equals(System.Object)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetHashCode'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetType'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.MemberwiseClone'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.ToString'.

xml/Microsoft.Build.ObjectModelRemoting/ProjectItemDefinitionLink.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.Equals(System.Object)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetHashCode'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetType'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.MemberwiseClone'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.ToString'.

xml/Microsoft.Build.Logging/BinaryLogger.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.Equals(System.Object)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetHashCode'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetType'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.MemberwiseClone'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.ToString'.

xml/Microsoft.Build.Tasks/CreateTemporaryVCProject.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.Build.Utilities.Task.BuildEngine3'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.Build.Utilities.Task.BuildEngine4'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.Build.Utilities.Task.BuildEngine5'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.Build.Utilities.Task.BuildEngine6'.

xml/Microsoft.Build.ObjectModelRemoting/ProjectOnErrorElementLink.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.Equals(System.Object)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetHashCode'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.GetType'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.MemberwiseClone'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Object.ToString'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@krwq krwq merged commit 3e9efd4 into dotnet:master Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartonjs bartonjs bartonjs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistence usage of type KeySizes in AesGcm (size in byte vs. size in bit)
3 participants
@krwq @opbld31 @bartonjs