Skip to content

Add CreateContentReadStreamAsync documentation to various Content classes #4747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

aik-jahoda
Copy link
Contributor

Summary

Add CreateContentReadStreamAsync documentation to various Content classes

part of: dotnet/runtime#41446

@aik-jahoda aik-jahoda force-pushed the jajahoda/contentCreateContent branch 2 times, most recently from 8587329 to 81899a4 Compare August 31, 2020 12:12
@opbld33

This comment has been minimized.

@aik-jahoda aik-jahoda force-pushed the jajahoda/contentCreateContent branch from 81899a4 to e62ccca Compare August 31, 2020 12:16
@opbld31

This comment has been minimized.

@aik-jahoda aik-jahoda force-pushed the jajahoda/contentCreateContent branch from 92f4a85 to e16287b Compare August 31, 2020 12:32
@opbld31

This comment has been minimized.

@opbld33

This comment has been minimized.

@carlossanlop carlossanlop requested review from a team August 31, 2020 23:32
Copy link
Contributor

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aik-jahoda for the change. I left one small suggestion.

Co-authored-by: Carlos Sanchez <1175054+carlossanlop@users.noreply.github.com>
@aik-jahoda aik-jahoda closed this Sep 1, 2020
@aik-jahoda
Copy link
Contributor Author

Reopen to trigger build.

@aik-jahoda aik-jahoda reopened this Sep 1, 2020
@aik-jahoda
Copy link
Contributor Author

aik-jahoda commented Sep 1, 2020

@carlossanlop, is it ok to have so many warnings above? It is easy to overlook current PR warnings.
Rerun helped.

@opbld33

This comment has been minimized.

@opbld33
Copy link

opbld33 commented Sep 1, 2020

Docs Build status updates of commit 85d0afb:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Net.Http/HttpContent.xml ✅Succeeded View
xml/System.Net.Http/MultipartContent.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@carlossanlop
Copy link
Contributor

@aik-jahoda good to know you were able to get rid of the warnings by retriggering the CI. I've been seeing all those unexpected warnings in the most recent PRs, but that seems to be the workaround.
It looks good now, I'll merge.

@carlossanlop carlossanlop merged commit e3b38ed into dotnet:master Sep 1, 2020
@aik-jahoda aik-jahoda deleted the jajahoda/contentCreateContent branch September 2, 2020 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants