-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add PhysicalAddress Parse methods documentation #4750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PhysicalAddress Parse methods documentation #4750
Conversation
This comment has been minimized.
This comment has been minimized.
@@ -0,0 +1,8 @@ | |||
<Project Sdk="Microsoft.NET.Sdk"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dotnet/docs do we allow adding csproj files to this location?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be nice to have guidance. I added the csproj to be able to run the example. It should be easy to run the example so I think it worth to have it part of the examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We expect the /samples/snippets folder has any samples. We've turned on a CI system in dotnet/docs, and we'll be adding it in this repo shortly. Once it's turned on, any PR that updates sample code will be run through the CI build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change, @aik-jahoda . I left a couple of suggestions for you to consider, and a question for @dotnet/docs regarding the addition of a csproj.
Co-authored-by: Carlos Sanchez <1175054+carlossanlop@users.noreply.github.com>
Docs Build status updates of commit c222cf3: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. I'll now.
Summary
Add PhysicalAddress (Try)Parse methods documentation
part of: dotnet/runtime#41446