Skip to content

Conversation

aik-jahoda
Copy link
Contributor

Summary

Add PhysicalAddress (Try)Parse methods documentation

part of: dotnet/runtime#41446

@opbld34

This comment has been minimized.

@@ -0,0 +1,8 @@
<Project Sdk="Microsoft.NET.Sdk">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dotnet/docs do we allow adding csproj files to this location?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be nice to have guidance. I added the csproj to be able to run the example. It should be easy to run the example so I think it worth to have it part of the examples.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We expect the /samples/snippets folder has any samples. We've turned on a CI system in dotnet/docs, and we'll be adding it in this repo shortly. Once it's turned on, any PR that updates sample code will be run through the CI build.

@carlossanlop carlossanlop requested review from a team August 31, 2020 23:29
Copy link
Contributor

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change, @aik-jahoda . I left a couple of suggestions for you to consider, and a question for @dotnet/docs regarding the addition of a csproj.

Co-authored-by: Carlos Sanchez <1175054+carlossanlop@users.noreply.github.com>
@opbld34
Copy link

opbld34 commented Sep 1, 2020

Docs Build status updates of commit c222cf3:

✅ Validation status: passed

File Status Preview URL Details
samples/snippets/csharp/VS_Snippets_Remoting/NCLPhysicalAddress/CS/NCLPhysicalAddress.csproj ✅Succeeded
samples/snippets/csharp/VS_Snippets_Remoting/NCLPhysicalAddress/CS/physaddresstester.cs ✅Succeeded View
xml/System.Net.NetworkInformation/PhysicalAddress.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. I'll :shipit: now.

@BillWagner BillWagner merged commit aee70ed into dotnet:master Sep 1, 2020
@aik-jahoda aik-jahoda deleted the jajahoda/PhysicalAddressParse branch September 2, 2020 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants