Skip to content

Add SslStream missing API documentation #4760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 1, 2020

Conversation

aik-jahoda
Copy link
Contributor

Summary

SslStream: add missing API documentation.

part of: dotnet/runtime#41446

@opbld34

This comment has been minimized.

@opbld33
Copy link

opbld33 commented Sep 1, 2020

Docs Build status updates of commit ab1d912:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/System.Net.Security/SslStream.xml ⚠️Warning View Details

xml/System.Net.Security/SslStream.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.IO.Stream.System#IDisposable#Dispose'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@aik-jahoda aik-jahoda requested review from a team and carlossanlop September 1, 2020 14:17
@aik-jahoda
Copy link
Contributor Author

I don't know what causes the invalid xref so I created an issue: #4763

@carlossanlop
Copy link
Contributor

The warning is indeed unrelated to your change and you opened an issue for it, so I think we can get this merged since it LGTM.

@carlossanlop carlossanlop merged commit 25fa174 into dotnet:master Sep 1, 2020
@aik-jahoda aik-jahoda deleted the jajahoda/SslStreamApi branch September 2, 2020 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants