-
Notifications
You must be signed in to change notification settings - Fork 1.6k
CI update for mdoc 5.8 #4804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI update for mdoc 5.8 #4804
Conversation
<remarks>To be added.</remarks> | ||
</Docs> | ||
</Member> | ||
<Member MemberName="Configure"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This member deletion is the only thing that seems "off" to me - the binaries haven't changed as far as I'm aware. @joelmartinez
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm ... looking at the changes to the framework index files, it doesn't show this member being deleted there, which suggests it was never actually a part of the manifest that mdoc published. Perhaps this is just an artifact from changes to the .net 5 preview? Seems like an anomaly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@carlossanlop Can you help me figure out why this is getting deleted from the docs? It appears to still be in the source code: https://github.com/dotnet/runtime/blob/a9f6fd69b362f0c4f986bd7bf241bf5ef7d06dce/src/libraries/Microsoft.Extensions.Logging/src/LoggingBuilderExtensions.cs#L58.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's still in the framework index file at https://raw.githubusercontent.com/dotnet/dotnet-api-docs/master/xml/FrameworksIndex/dotnet-plat-ext-5.0.xml:
<Member Id="M:Microsoft.Extensions.Logging.LoggingBuilderExtensions.Configure(Microsoft.Extensions.Logging.ILoggingBuilder,System.Action{Microsoft.Extensions.Logging.LoggerFactoryOptions})" />
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also tagging @safern for comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gewarren ok ... I've created a bug to track this issue:
https://ceapex.visualstudio.com/Engineering/_workitems/edit/298401
We'll figure out what's happening and include the fix in the next release. In the meantime, you could work around the issue by manually adding this method back into the XML before merging this branch.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Bill or Joel, could you approve this PR please? I'll add the deleted method back separately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
No description provided.