Skip to content

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Sep 4, 2020

No description provided.

<remarks>To be added.</remarks>
</Docs>
</Member>
<Member MemberName="Configure">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This member deletion is the only thing that seems "off" to me - the binaries haven't changed as far as I'm aware. @joelmartinez

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm ... looking at the changes to the framework index files, it doesn't show this member being deleted there, which suggests it was never actually a part of the manifest that mdoc published. Perhaps this is just an artifact from changes to the .net 5 preview? Seems like an anomaly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carlossanlop Can you help me figure out why this is getting deleted from the docs? It appears to still be in the source code: https://github.com/dotnet/runtime/blob/a9f6fd69b362f0c4f986bd7bf241bf5ef7d06dce/src/libraries/Microsoft.Extensions.Logging/src/LoggingBuilderExtensions.cs#L58.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still in the framework index file at https://raw.githubusercontent.com/dotnet/dotnet-api-docs/master/xml/FrameworksIndex/dotnet-plat-ext-5.0.xml:

<Member Id="M:Microsoft.Extensions.Logging.LoggingBuilderExtensions.Configure(Microsoft.Extensions.Logging.ILoggingBuilder,System.Action{Microsoft.Extensions.Logging.LoggerFactoryOptions})" />

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also tagging @safern for comment.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gewarren ok ... I've created a bug to track this issue:
https://ceapex.visualstudio.com/Engineering/_workitems/edit/298401

We'll figure out what's happening and include the fix in the next release. In the meantime, you could work around the issue by manually adding this method back into the XML before merging this branch.

@opbld34

This comment has been minimized.

@opbld30

This comment has been minimized.

@opbld33
Copy link

opbld33 commented Sep 8, 2020

Docs Build status updates of commit 2cf90f1:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/Microsoft.Extensions.Caching.Memory/MemoryCacheOptions.xml ⚠️Warning View Details
xml/Microsoft.Extensions.DependencyInjection/DefaultServiceProviderFactory.xml ⚠️Warning View Details
xml/FrameworksIndex/net-5.0.xml ✅Succeeded
xml/FrameworksIndex/netcore-3.0.xml ✅Succeeded
xml/FrameworksIndex/netcore-3.1.xml ✅Succeeded
xml/FrameworksIndex/netframework-1.1.xml ✅Succeeded
xml/FrameworksIndex/netframework-2.0.xml ✅Succeeded
xml/FrameworksIndex/netframework-3.0.xml ✅Succeeded
xml/FrameworksIndex/netframework-3.5.xml ✅Succeeded
xml/FrameworksIndex/netframework-4.0.xml ✅Succeeded
xml/FrameworksIndex/netframework-4.5.1.xml ✅Succeeded
xml/FrameworksIndex/netframework-4.5.2.xml ✅Succeeded
xml/FrameworksIndex/netframework-4.5.xml ✅Succeeded
xml/FrameworksIndex/netframework-4.6.1.xml ✅Succeeded
xml/FrameworksIndex/netframework-4.6.2.xml ✅Succeeded
xml/FrameworksIndex/netframework-4.6.xml ✅Succeeded
xml/FrameworksIndex/netframework-4.7.1.xml ✅Succeeded
xml/FrameworksIndex/netframework-4.7.2.xml ✅Succeeded
xml/FrameworksIndex/netframework-4.7.xml ✅Succeeded
xml/FrameworksIndex/netframework-4.8.xml ✅Succeeded
xml/FrameworksIndex/xamarinmac-3.0.xml ✅Succeeded
xml/Microsoft.Build.Globbing/MSBuildGlob.xml ✅Succeeded View
xml/Microsoft.Extensions.Caching.Memory/MemoryCache.xml ✅Succeeded View
xml/Microsoft.Extensions.Configuration/ChainedConfigurationProvider.xml ✅Succeeded View
xml/Microsoft.Extensions.Configuration/ConfigurationRoot.xml ✅Succeeded View
xml/Microsoft.Extensions.Configuration/FileConfigurationProvider.xml ✅Succeeded View
xml/Microsoft.Extensions.DependencyInjection/ServiceCollection.xml ✅Succeeded View
xml/Microsoft.Extensions.FileProviders.Composite/CompositeDirectoryContents.xml ✅Succeeded View
xml/Microsoft.Extensions.FileProviders.Embedded/EmbeddedResourceFileInfo.xml ✅Succeeded View
xml/Microsoft.Extensions.FileProviders.Internal/PhysicalDirectoryContents.xml ✅Succeeded
xml/Microsoft.Extensions.FileProviders.Physical/PhysicalDirectoryInfo.xml ✅Succeeded View
xml/Microsoft.Extensions.FileProviders.Physical/PhysicalFileInfo.xml ✅Succeeded View
xml/Microsoft.Extensions.FileProviders.Physical/PollingWildCardChangeToken.xml ✅Succeeded View
xml/Microsoft.Extensions.FileProviders/ManifestEmbeddedFileProvider.xml ✅Succeeded View
xml/Microsoft.Extensions.FileProviders/NotFoundDirectoryContents.xml ✅Succeeded View
xml/Microsoft.Extensions.FileProviders/NotFoundFileInfo.xml ✅Succeeded View
xml/Microsoft.Extensions.Hosting.Internal/ConsoleLifetime.xml ✅Succeeded
xml/Microsoft.Extensions.Hosting.Internal/HostingEnvironment.xml ✅Succeeded
xml/Microsoft.Extensions.Hosting/BackgroundService.xml ✅Succeeded View
xml/Microsoft.Extensions.Logging/ConsoleLoggerExtensions.xml ✅Succeeded View
xml/Microsoft.Extensions.Logging/LoggingBuilderExtensions.xml ✅Succeeded View
xml/Microsoft.Extensions.Options/ConfigurationChangeTokenSource`1.xml ✅Succeeded View
xml/System.Configuration/ConfigurationSettings.xml ✅Succeeded View
xml/System.Diagnostics/Activity.xml ✅Succeeded View
xml/System.Diagnostics/ActivityListener.xml ✅Succeeded View
xml/System.Security.Cryptography/SHA256.xml ✅Succeeded View
xml/System.Windows.Forms/AccessibleObject.xml ✅Succeeded View
xml/System.Xml.Xsl.Runtime/XmlQueryNodeSequence.xml ✅Succeeded View
xml/System/Half.xml ✅Succeeded View

xml/Microsoft.Extensions.Caching.Memory/MemoryCacheOptions.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.Extensions.Internal.ISystemClock'.

xml/Microsoft.Extensions.DependencyInjection/DefaultServiceProviderFactory.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.Extensions.DependencyInjection.ServiceProviderOptions.Default'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@gewarren gewarren requested a review from BillWagner September 8, 2020 23:44
@gewarren
Copy link
Contributor Author

gewarren commented Sep 8, 2020

Bill or Joel, could you approve this PR please? I'll add the deleted method back separately.

Copy link
Contributor

@joelmartinez joelmartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@gewarren gewarren merged commit 8eb91b6 into master Sep 9, 2020
@gewarren gewarren deleted the mdoc-updates-0904 branch September 9, 2020 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants