Skip to content

Conversation

tarekgh
Copy link
Member

@tarekgh tarekgh commented Sep 8, 2020

Summary

Add missing docs of the following APIs:

M:System.Text.CodePagesEncodingProvider.GetEncodings
T:System.Text.EncodingExtensions
M:System.Text.EncodingExtensions.GetBytes   (System.Text.Encoding,System.ReadOnlySpan{System.Char},   System.Buffers.IBufferWriter{System.Byte})
M:System.Text.EncodingProvider.GetEncodings

@tarekgh
Copy link
Member Author

tarekgh commented Sep 8, 2020

CC @carlossanlop

@opbld33
Copy link

opbld33 commented Sep 8, 2020

Docs Build status updates of commit fafdfda:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Text/CodePagesEncodingProvider.xml ✅Succeeded View
xml/System.Text/Encoding.xml ✅Succeeded View
xml/System.Text/EncodingExtensions.xml ✅Succeeded View
xml/System.Text/EncodingProvider.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld30
Copy link

opbld30 commented Sep 9, 2020

Docs Build status updates of commit 466c5f0:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Text/CodePagesEncodingProvider.xml ✅Succeeded View
xml/System.Text/Encoding.xml ✅Succeeded View
xml/System.Text/EncodingExtensions.xml ✅Succeeded View
xml/System.Text/EncodingProvider.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld32
Copy link

opbld32 commented Sep 9, 2020

Docs Build status updates of commit 5d6997b:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Text/CodePagesEncodingProvider.xml ✅Succeeded View
xml/System.Text/Encoding.xml ✅Succeeded View
xml/System.Text/EncodingExtensions.xml ✅Succeeded View
xml/System.Text/EncodingProvider.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@opbld32
Copy link

opbld32 commented Sep 11, 2020

Docs Build status updates of commit f1e88c1:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Text/CodePagesEncodingProvider.xml ✅Succeeded View
xml/System.Text/Encoding.xml ✅Succeeded View
xml/System.Text/EncodingExtensions.xml ✅Succeeded View
xml/System.Text/EncodingProvider.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Copy link

@pgovind pgovind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just agree with the simplification that @carlossanlop proposed in 1 comment. Otherwise this is looking good.

@opbld33
Copy link

opbld33 commented Sep 11, 2020

Docs Build status updates of commit 58203bb:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Text/CodePagesEncodingProvider.xml ✅Succeeded View
xml/System.Text/Encoding.xml ✅Succeeded View
xml/System.Text/EncodingExtensions.xml ✅Succeeded View
xml/System.Text/EncodingProvider.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Co-authored-by: Carlos Sanchez <1175054+carlossanlop@users.noreply.github.com>
@opbld31
Copy link

opbld31 commented Sep 11, 2020

Docs Build status updates of commit 795e5da:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Text/CodePagesEncodingProvider.xml ✅Succeeded View
xml/System.Text/Encoding.xml ✅Succeeded View
xml/System.Text/EncodingExtensions.xml ✅Succeeded View
xml/System.Text/EncodingProvider.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@opbld32
Copy link

opbld32 commented Sep 11, 2020

Docs Build status updates of commit 5fa468c:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Text/CodePagesEncodingProvider.xml ✅Succeeded View
xml/System.Text/Encoding.xml ✅Succeeded View
xml/System.Text/EncodingExtensions.xml ✅Succeeded View
xml/System.Text/EncodingProvider.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@gewarren gewarren merged commit bb4295b into dotnet:master Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants