Skip to content

Conversation

v-mepa
Copy link
Contributor

@v-mepa v-mepa commented Sep 10, 2020

fyi @mairaw

Add try dotnet to batch 21b

URL Try .NET Status Comments
https://docs.microsoft.com/en-us/dotnet/api/system.single Batch 21 Except for the samples that use Single.dat file on the code (4 and 5), 13 (loop), 14 (different output)
https://docs.microsoft.com/en-us/dotnet/api/system.datetime.hour Batch 21 Second sample only. First has no output
https://docs.microsoft.com/en-us/dotnet/api/system.invalidcastexception Batch 21 Samples 1, 2, 5. Remaining samples are not runnable or throw exceptions
https://docs.microsoft.com/en-us/dotnet/api/system.array.copyto Batch 21 Duplicate samples for all overloads? Potentially move it to the MemberGroup. Include using statement on the second example.
https://docs.microsoft.com/en-us/dotnet/api/system.enum.isdefined Batch 21  
https://docs.microsoft.com/en-us/dotnet/api/system.datetime.day Batch 21 Second sample only. First has no output; third has to be modified to work (could use CultureInfo.CurrentCulture, check output)
https://docs.microsoft.com/en-us/dotnet/api/system.globalization.calendar.getweekofyear Batch 21 First example only. Second is culture dependent
https://docs.microsoft.com/en-us/dotnet/api/system.globalization.numberstyles Batch 21  
https://docs.microsoft.com/en-us/dotnet/api/system.array.binarysearch Batch 21  
https://docs.microsoft.com/en-us/dotnet/api/system.uribuilder.fragment Batch 21  

@opbld33
Copy link

opbld33 commented Sep 10, 2020

Docs Build status updates of commit 90b275a:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Globalization/Calendar.xml ✅Succeeded View
xml/System.Globalization/NumberStyles.xml ✅Succeeded View
xml/System/Array.xml ✅Succeeded View
xml/System/DateTime.xml ✅Succeeded View
xml/System/Enum.xml ✅Succeeded View
xml/System/InvalidCastException.xml ✅Succeeded View
xml/System/Single.xml ✅Succeeded View
xml/System/UriBuilder.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@mairaw mairaw self-requested a review September 10, 2020 22:40
@mairaw mairaw added the 👩‍💻 .NET Interactive These issues relate to using .NET Interactive in docs label Sep 10, 2020
@opbld32
Copy link

opbld32 commented Sep 11, 2020

Docs Build status updates of commit 43e56a2:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/System/Array.xml ⚠️Warning View Details
samples/snippets/csharp/VS_Snippets_CLR_Classic/classic Array.CopyTo Example/CS/source.cs ✅Succeeded View
xml/System.Globalization/Calendar.xml ✅Succeeded View
xml/System.Globalization/NumberStyles.xml ✅Succeeded View
xml/System/DateTime.xml ✅Succeeded View
xml/System/Enum.xml ✅Succeeded View
xml/System/InvalidCastException.xml ✅Succeeded View
xml/System/Single.xml ✅Succeeded View
xml/System/UriBuilder.xml ✅Succeeded View

xml/System/Array.xml

  • Line 0, Column 0: [Warning-invalid-code] It looks like your code snippet was not rendered. Try range instead.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @v-mepa. A few things to address before we merge...

@opbld33
Copy link

opbld33 commented Sep 11, 2020

Docs Build status updates of commit 5b96a5b:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/System/Array.xml ⚠️Warning View Details
samples/snippets/cpp/VS_Snippets_CLR_Classic/classic Array.CopyTo Example/CPP/source.cpp ✅Succeeded View
samples/snippets/cpp/VS_Snippets_CLR_Classic/classic Array.CopyTo Example/CPP/source2.cpp ✅Succeeded
samples/snippets/csharp/VS_Snippets_CLR_Classic/classic Array.CopyTo Example/CS/source.cs ✅Succeeded View
samples/snippets/csharp/VS_Snippets_CLR_Classic/classic Array.CopyTo Example/CS/source2.cs ✅Succeeded
samples/snippets/visualbasic/VS_Snippets_CLR_Classic/classic Array.CopyTo Example/VB/source.vb ✅Succeeded View
samples/snippets/visualbasic/VS_Snippets_CLR_Classic/classic Array.CopyTo Example/VB/source2.vb ✅Succeeded
xml/System.Globalization/Calendar.xml ✅Succeeded View
xml/System.Globalization/NumberStyles.xml ✅Succeeded View
xml/System/DateTime.xml ✅Succeeded View
xml/System/Enum.xml ✅Succeeded View
xml/System/InvalidCastException.xml ✅Succeeded View
xml/System/Single.xml ✅Succeeded View
xml/System/UriBuilder.xml ✅Succeeded View

xml/System/Array.xml

  • Line 0, Column 0: [Warning-invalid-code] It looks like your code snippet was not rendered. Try range instead.
  • Line 0, Column 0: [Warning-invalid-code] It looks like your code snippet was not rendered. Try range instead.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@mairaw
Copy link
Contributor

mairaw commented Sep 11, 2020

I've applied all the changes.

@opbld32
Copy link

opbld32 commented Sep 11, 2020

Docs Build status updates of commit 863812e:

✅ Validation status: passed

File Status Preview URL Details
samples/snippets/cpp/VS_Snippets_CLR_Classic/classic Array.CopyTo Example/CPP/source.cpp ✅Succeeded View
samples/snippets/cpp/VS_Snippets_CLR_Classic/classic Array.CopyTo Example/CPP/source2.cpp ✅Succeeded View
samples/snippets/csharp/VS_Snippets_CLR_Classic/classic Array.CopyTo Example/CS/source.cs ✅Succeeded View
samples/snippets/csharp/VS_Snippets_CLR_Classic/classic Array.CopyTo Example/CS/source2.cs ✅Succeeded View
samples/snippets/visualbasic/VS_Snippets_CLR_Classic/classic Array.CopyTo Example/VB/source.vb ✅Succeeded View
samples/snippets/visualbasic/VS_Snippets_CLR_Classic/classic Array.CopyTo Example/VB/source2.vb ✅Succeeded View
xml/System.Globalization/Calendar.xml ✅Succeeded View
xml/System.Globalization/NumberStyles.xml ✅Succeeded View
xml/System/Array.xml ✅Succeeded View
xml/System/DateTime.xml ✅Succeeded View
xml/System/Enum.xml ✅Succeeded View
xml/System/InvalidCastException.xml ✅Succeeded View
xml/System/Single.xml ✅Succeeded View
xml/System/UriBuilder.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld33
Copy link

opbld33 commented Sep 11, 2020

Docs Build status updates of commit db3c484:

✅ Validation status: passed

File Status Preview URL Details
samples/snippets/cpp/VS_Snippets_CLR_Classic/classic Array.CopyTo Example/CPP/source.cpp ✅Succeeded View
samples/snippets/cpp/VS_Snippets_CLR_Classic/classic Array.CopyTo Example/CPP/source2.cpp ✅Succeeded View
samples/snippets/csharp/VS_Snippets_CLR_Classic/classic Array.CopyTo Example/CS/source.cs ✅Succeeded View
samples/snippets/csharp/VS_Snippets_CLR_Classic/classic Array.CopyTo Example/CS/source2.cs ✅Succeeded View
samples/snippets/visualbasic/VS_Snippets_CLR_Classic/classic Array.CopyTo Example/VB/source.vb ✅Succeeded View
samples/snippets/visualbasic/VS_Snippets_CLR_Classic/classic Array.CopyTo Example/VB/source2.vb ✅Succeeded View
xml/System.Globalization/Calendar.xml ✅Succeeded View
xml/System.Globalization/NumberStyles.xml ✅Succeeded View
xml/System/Array.xml ✅Succeeded View
xml/System/DateTime.xml ✅Succeeded View
xml/System/Enum.xml ✅Succeeded View
xml/System/InvalidCastException.xml ✅Succeeded View
xml/System/Single.xml ✅Succeeded View
xml/System/UriBuilder.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld34
Copy link

opbld34 commented Sep 11, 2020

Docs Build status updates of commit b089576:

✅ Validation status: passed

File Status Preview URL Details
samples/snippets/cpp/VS_Snippets_CLR_Classic/classic Array.CopyTo Example/CPP/source.cpp ✅Succeeded View
samples/snippets/cpp/VS_Snippets_CLR_Classic/classic Array.CopyTo Example/CPP/source2.cpp ✅Succeeded View
samples/snippets/csharp/VS_Snippets_CLR_Classic/classic Array.CopyTo Example/CS/source.cs ✅Succeeded View
samples/snippets/csharp/VS_Snippets_CLR_Classic/classic Array.CopyTo Example/CS/source2.cs ✅Succeeded View
samples/snippets/visualbasic/VS_Snippets_CLR_Classic/classic Array.CopyTo Example/VB/source.vb ✅Succeeded View
samples/snippets/visualbasic/VS_Snippets_CLR_Classic/classic Array.CopyTo Example/VB/source2.vb ✅Succeeded View
xml/System.Globalization/Calendar.xml ✅Succeeded View
xml/System.Globalization/NumberStyles.xml ✅Succeeded View
xml/System/Array.xml ✅Succeeded View
xml/System/DateTime.xml ✅Succeeded View
xml/System/Enum.xml ✅Succeeded View
xml/System/InvalidCastException.xml ✅Succeeded View
xml/System/Single.xml ✅Succeeded View
xml/System/UriBuilder.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@mairaw mairaw merged commit 08162c6 into dotnet:master Sep 11, 2020
@v-mepa v-mepa deleted the add_try_dotnet_to_batch_21b branch September 30, 2020 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

👩‍💻 .NET Interactive These issues relate to using .NET Interactive in docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants