Skip to content

Conversation

dsychin
Copy link
Contributor

@dsychin dsychin commented Oct 4, 2020

Summary

Add VB examples for MailMessage

Fixes #981

Dear Maintainers,
I see that the other dotnet repos have the hacktoberfest topic.
Can you also add it to this repo?

@opbld30
Copy link

opbld30 commented Oct 4, 2020

Docs Build status updates of commit 97ad182:

✅ Validation status: passed

File Status Preview URL Details
samples/snippets/visualbasic/VS_Snippets_Remoting/NCLMailSync/vb/mail.vb ✅Succeeded View
xml/System.Net.Mail/MailMessage.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld30
Copy link

opbld30 commented Oct 4, 2020

Docs Build status updates of commit 3f81355:

✅ Validation status: passed

File Status Preview URL Details
samples/snippets/visualbasic/VS_Snippets_Remoting/NCLMailSync/vb/mail.vb ✅Succeeded View
xml/System.Net.Mail/MailMessage.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The preview looks good and I verified that the code compiles. @dsychin Thanks very much!

@@ -938,6 +947,7 @@

[!code-cpp[NclMailSync#10](~/samples/snippets/cpp/VS_Snippets_Remoting/NCLMailSync/CPP/NclMailSync.cpp#10)]
[!code-csharp[NclMailSync#10](~/samples/snippets/csharp/VS_Snippets_Remoting/NCLMailSync/CS/mail.cs#10)]
[!code-vb[NclMailSync#10](~/samples/snippets/visualbasic/VS_Snippets_Remoting/NCLMailSync/vb/mail.vb#10)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see where the From property is explicitly set, but this is not unique to the snippet you added.

@@ -1468,6 +1480,7 @@

[!code-cpp[NclMailSync#7](~/samples/snippets/cpp/VS_Snippets_Remoting/NCLMailSync/CPP/NclMailSync.cpp#7)]
[!code-csharp[NclMailSync#7](~/samples/snippets/csharp/VS_Snippets_Remoting/NCLMailSync/CS/mail.cs#7)]
[!code-vb[NclMailSync#7](~/samples/snippets/visualbasic/VS_Snippets_Remoting/NCLMailSync/vb/mail.vb#7)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as for From - I don't see where it's being set.

@gewarren gewarren merged commit 3bdc492 into dotnet:master Oct 22, 2020
@dsychin dsychin deleted the mail-message branch October 23, 2020 01:46
@eiriktsarpalis eiriktsarpalis added the area-WPF Issues or PRs that relate to WPF or XAML. label Mar 1, 2021
@carlossanlop carlossanlop added area-System.Net and removed area-WPF Issues or PRs that relate to WPF or XAML. labels Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing VB version of the sample - MailMessage
5 participants