-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add VB examples for MailMessage #4944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Docs Build status updates of commit 97ad182: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Docs Build status updates of commit 3f81355: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The preview looks good and I verified that the code compiles. @dsychin Thanks very much!
@@ -938,6 +947,7 @@ | |||
|
|||
[!code-cpp[NclMailSync#10](~/samples/snippets/cpp/VS_Snippets_Remoting/NCLMailSync/CPP/NclMailSync.cpp#10)] | |||
[!code-csharp[NclMailSync#10](~/samples/snippets/csharp/VS_Snippets_Remoting/NCLMailSync/CS/mail.cs#10)] | |||
[!code-vb[NclMailSync#10](~/samples/snippets/visualbasic/VS_Snippets_Remoting/NCLMailSync/vb/mail.vb#10)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see where the From property is explicitly set, but this is not unique to the snippet you added.
@@ -1468,6 +1480,7 @@ | |||
|
|||
[!code-cpp[NclMailSync#7](~/samples/snippets/cpp/VS_Snippets_Remoting/NCLMailSync/CPP/NclMailSync.cpp#7)] | |||
[!code-csharp[NclMailSync#7](~/samples/snippets/csharp/VS_Snippets_Remoting/NCLMailSync/CS/mail.cs#7)] | |||
[!code-vb[NclMailSync#7](~/samples/snippets/visualbasic/VS_Snippets_Remoting/NCLMailSync/vb/mail.vb#7)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as for From
- I don't see where it's being set.
Summary
Add VB examples for MailMessage
Fixes #981
Dear Maintainers,
I see that the other dotnet repos have the
hacktoberfest
topic.Can you also add it to this repo?