Skip to content

Add usage note to DisablePrivateReflectionAttribute #4969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2020

Conversation

GrabYourPitchforks
Copy link
Member

Summary

Add a note that DisablePrivateReflectionAttribute isn't consistently enforced by any runtime.

Fixes #4646

@opbld31
Copy link

opbld31 commented Oct 10, 2020

Docs Build status updates of commit 7f90f0f:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Runtime.CompilerServices/DisablePrivateReflectionAttribute.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@GrabYourPitchforks
Copy link
Member Author

Anything else I need to do here, or can I hit the friendly green merge button?

@gewarren
Copy link
Contributor

You're good to merge it from my POV!

@GrabYourPitchforks GrabYourPitchforks merged commit 4da95d1 into dotnet:master Oct 22, 2020
@GrabYourPitchforks GrabYourPitchforks deleted the privref branch October 22, 2020 01:34
@GrabYourPitchforks
Copy link
Member Author

Thanks kindly for the review! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking: DisablePrivateReflectionAttribute no longer supported as of .NET Core 2.1+
4 participants