Skip to content

Remove MSDN library references - 4 #5231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 14, 2021
Merged

Remove MSDN library references - 4 #5231

merged 3 commits into from
Jan 14, 2021

Conversation

gewarren
Copy link
Contributor

Contributes to #5221 .

@gewarren gewarren requested review from mairaw and a team January 14, 2021 00:31
@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@opbld32
Copy link

opbld32 commented Jan 14, 2021

Docs Build status updates of commit d35cb3c:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/System.Runtime.InteropServices.ComTypes/IMPLTYPEFLAGS.xml ⚠️Warning View Details
xml/System.Runtime.InteropServices.ComTypes/BINDPTR.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/BIND_OPTS.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/CONNECTDATA.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/DATADIR.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/DESCKIND.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/DVASPECT.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/ELEMDESC.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/EXCEPINFO.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/FILETIME.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/FORMATETC.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/FUNCDESC.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/FUNCFLAGS.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/FUNCKIND.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/IAdviseSink.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/IDLDESC.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/IDataObject.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/IEnumConnectionPoints.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/IEnumConnections.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/IEnumFORMATETC.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/IEnumMoniker.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/IEnumSTATDATA.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/IEnumString.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/IEnumVARIANT.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/IMoniker.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/INVOKEKIND.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/ITypeComp.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/ITypeInfo.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/ITypeInfo2.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/ITypeLib.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/ITypeLib2.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/LIBFLAGS.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/PARAMDESC.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/STATDATA.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/STATSTG.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/STGMEDIUM.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/SYSKIND.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/TYMED.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/TYPEATTR.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/TYPEDESC.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/TYPEFLAGS.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/TYPEKIND.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/TYPELIBATTR.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/VARDESC.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/VARFLAGS.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/VARKIND.xml ✅Succeeded View

xml/System.Runtime.InteropServices.ComTypes/IMPLTYPEFLAGS.xml

  • Line 0, Column 0: [Warning-file-not-found] Invalid file link: 'previous-versions/windows/embedded/ms882821(v=msdn.10)'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@opbld30
Copy link

opbld30 commented Jan 14, 2021

Docs Build status updates of commit 467c6e8:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Runtime.InteropServices.ComTypes/BINDPTR.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/BIND_OPTS.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/CONNECTDATA.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/DATADIR.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/DESCKIND.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/DVASPECT.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/ELEMDESC.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/EXCEPINFO.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/FILETIME.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/FORMATETC.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/FUNCDESC.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/FUNCFLAGS.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/FUNCKIND.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/IAdviseSink.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/IDLDESC.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/IDataObject.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/IEnumConnectionPoints.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/IEnumConnections.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/IEnumFORMATETC.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/IEnumMoniker.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/IEnumSTATDATA.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/IEnumString.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/IEnumVARIANT.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/IMPLTYPEFLAGS.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/IMoniker.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/INVOKEKIND.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/ITypeComp.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/ITypeInfo.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/ITypeInfo2.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/ITypeLib.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/ITypeLib2.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/LIBFLAGS.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/PARAMDESC.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/STATDATA.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/STATSTG.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/STGMEDIUM.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/SYSKIND.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/TYMED.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/TYPEATTR.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/TYPEDESC.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/TYPEFLAGS.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/TYPEKIND.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/TYPELIBATTR.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/VARDESC.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/VARFLAGS.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ComTypes/VARKIND.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

mairaw
mairaw approved these changes Jan 14, 2021
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quickly looked over the changes and tested a few and they look good. LGTM

BillWagner
BillWagner approved these changes Jan 14, 2021
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

You can :shipit: when ready.

@gewarren gewarren merged commit cac5473 into dotnet:master Jan 14, 2021
@gewarren gewarren deleted the comtypes branch January 14, 2021 16:24
@gewarren
Copy link
Contributor Author

Thanks Maira and Bill!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

@mairaw mairaw mairaw approved these changes

Assignees
No one assigned
Labels
area-System.Runtime.InteropServices
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gewarren @Dotnet-GitSync-Bot @opbld32 @opbld30 @BillWagner @mairaw @eiriktsarpalis