-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Replace MSDN links #5242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace MSDN links #5242
Conversation
Build.Reason:Manual by Genevieve Warren Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=187341&view=results
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Docs Build status updates of commit fce812f: 🕙 Pending: waiting for processors (36 builds ahead of you) |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still going through this PR but leaving some comments for now
xml/Microsoft.VisualBasic.ApplicationServices/ApplicationBase.xml
Outdated
Show resolved
Hide resolved
xml/Microsoft.VisualBasic.ApplicationServices/ApplicationBase.xml
Outdated
Show resolved
Hide resolved
xml/Microsoft.VisualBasic.ApplicationServices/WindowsFormsApplicationBase.xml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more comments
xml/System.ComponentModel.Design.Serialization/DesignerSerializerAttribute.xml
Outdated
Show resolved
Hide resolved
xml/System.ComponentModel.Design.Serialization/DesignerSerializerAttribute.xml
Outdated
Show resolved
Hide resolved
xml/System.ComponentModel.Design.Serialization/DesignerSerializerAttribute.xml
Outdated
Show resolved
Hide resolved
xml/System.ComponentModel.Design.Serialization/DesignerSerializerAttribute.xml
Outdated
Show resolved
Hide resolved
xml/System.ComponentModel.Design.Serialization/DesignerSerializerAttribute.xml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more...
xml/System.ComponentModel.Design/DesignerActionPropertyItem.xml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final comments...
Co-authored-by: Maira Wenzel <mairaw@microsoft.com>
Co-authored-by: Maira Wenzel <mairaw@microsoft.com>
Thanks Maira for the very thorough review! I will look more closely next time I run the CI job. |
Docs Build status updates of commit da69020: ✅ Validation status: passed
This comment lists only the first 50 files in the pull request. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
No worries! That's why I left these options for later because they're a bit trickier 😉 |
The product team is hoping to move the source of truth to the dotnet/runtime repo in the .NET 6 timeframe. So I wanted to run the CI tool while we still had it available. I will do a smaller chunk next time. |
No description provided.