Skip to content

Replace MSDN links #5242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 19, 2021
Merged

Replace MSDN links #5242

merged 5 commits into from
Jan 19, 2021

Conversation

gewarren
Copy link
Contributor

No description provided.

VSC-Service-Account and others added 2 commits January 14, 2021 01:19
@ghost
Copy link

ghost commented Jan 15, 2021

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@opbld32
Copy link

opbld32 commented Jan 15, 2021

Docs Build status updates of commit fce812f:

🕙 Pending: waiting for processors (36 builds ahead of you)

⚠️ Docs Build is busy, currently there are 36 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

@opbld33

This comment has been minimized.

@gewarren gewarren requested review from mairaw and a team January 15, 2021 23:36
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still going through this PR but leaving some comments for now

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more comments

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more...

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final comments...

gewarren and others added 3 commits January 19, 2021 11:51
Co-authored-by: Maira Wenzel <mairaw@microsoft.com>
Co-authored-by: Maira Wenzel <mairaw@microsoft.com>
@gewarren
Copy link
Contributor Author

Thanks Maira for the very thorough review! I will look more closely next time I run the CI job.

@opbld31
Copy link

opbld31 commented Jan 19, 2021

Docs Build status updates of commit 08db904:

✅ Validation status: passed

File Status Preview URL Details
xml/Microsoft.Build.Tasks/CallTarget.xml ✅Succeeded View
xml/Microsoft.Build.Tasks/MSBuild.xml ✅Succeeded View
xml/Microsoft.Build.Tasks/ResolveComReference.xml ✅Succeeded View
xml/Microsoft.JScript/ErrorType.xml ✅Succeeded View
xml/Microsoft.JScript/EvalErrorObject.xml ✅Succeeded View
xml/Microsoft.VisualBasic.ApplicationServices/ApplicationBase.xml ✅Succeeded View
xml/Microsoft.VisualBasic.ApplicationServices/WindowsFormsApplicationBase.xml ✅Succeeded View
xml/Microsoft.VisualBasic.MyServices/ClipboardProxy.xml ✅Succeeded View
xml/Microsoft.VisualBasic/Collection.xml ✅Succeeded View
xml/Microsoft.VisualBasic/ErrObject.xml ✅Succeeded View
xml/Microsoft.VisualBasic/Interaction.xml ✅Succeeded View
xml/Microsoft.VisualC.StlClr/GenericPair`2.xml ✅Succeeded View
xml/Microsoft.Win32/FileDialog.xml ✅Succeeded View
xml/System.Activities.Statements/CompensableActivity.xml ✅Succeeded View
xml/System.Activities.Statements/CompensationToken.xml ✅Succeeded View
xml/System.AddIn.Contract/IListContract`1.xml ✅Succeeded View
xml/System.AddIn.Hosting/AddInEnvironment.xml ✅Succeeded View
xml/System.AddIn.Hosting/AddInProcess.xml ✅Succeeded View
xml/System.AddIn.Hosting/AddInSecurityLevel.xml ✅Succeeded View
xml/System.AddIn.Hosting/AddInSegmentDirectoryNotFoundException.xml ✅Succeeded View
xml/System.AddIn.Hosting/AddInStore.xml ✅Succeeded View
xml/System.AddIn.Hosting/AddInToken.xml ✅Succeeded View
xml/System.AddIn.Pipeline/AddInAdapterAttribute.xml ✅Succeeded View
xml/System.AddIn.Pipeline/AddInBaseAttribute.xml ✅Succeeded View
xml/System.AddIn.Pipeline/AddInContractAttribute.xml ✅Succeeded View
xml/System.AddIn.Pipeline/CollectionAdapters.xml ✅Succeeded View
xml/System.AddIn.Pipeline/ContractBase.xml ✅Succeeded View
xml/System.AddIn.Pipeline/HostAdapterAttribute.xml ✅Succeeded View
xml/System.AddIn/AddInAttribute.xml ✅Succeeded View
xml/System.Collections.Generic/List`1.xml ✅Succeeded View
xml/System.Collections.Generic/Stack`1.xml ✅Succeeded View
xml/System.Collections/IEnumerable.xml ✅Succeeded View
xml/System.ComponentModel.DataAnnotations/DataType.xml ✅Succeeded View
xml/System.ComponentModel.DataAnnotations/DataTypeAttribute.xml ✅Succeeded View
xml/System.ComponentModel.DataAnnotations/DisplayFormatAttribute.xml ✅Succeeded View
xml/System.ComponentModel.DataAnnotations/RangeAttribute.xml ✅Succeeded View
xml/System.ComponentModel.DataAnnotations/ScaffoldColumnAttribute.xml ✅Succeeded View
xml/System.ComponentModel.DataAnnotations/ScaffoldTableAttribute.xml ✅Succeeded View
xml/System.ComponentModel.DataAnnotations/UIHintAttribute.xml ✅Succeeded View
xml/System.ComponentModel.DataAnnotations/ValidationException.xml ✅Succeeded View
xml/System.ComponentModel.Design.Serialization/DesignerSerializerAttribute.xml ✅Succeeded View
xml/System.ComponentModel.Design/ComponentDesigner.xml ✅Succeeded View
xml/System.ComponentModel.Design/DesignerActionPropertyItem.xml ✅Succeeded View
xml/System.ComponentModel/AsyncOperation.xml ✅Succeeded View
xml/System.ComponentModel/AsyncOperationManager.xml ✅Succeeded View
xml/System.ComponentModel/AttributeProviderAttribute.xml ✅Succeeded View
xml/System.ComponentModel/DesignerSerializationVisibilityAttribute.xml ✅Succeeded View
xml/System.ComponentModel/EditorAttribute.xml ✅Succeeded View
xml/System.ComponentModel/ICustomTypeDescriptor.xml ✅Succeeded View
xml/System.ComponentModel/IExtenderProvider.xml ✅Succeeded View

This comment lists only the first 50 files in the pull request.
For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld34
Copy link

opbld34 commented Jan 19, 2021

Docs Build status updates of commit da69020:

✅ Validation status: passed

File Status Preview URL Details
xml/Microsoft.Build.Tasks/CallTarget.xml ✅Succeeded View
xml/Microsoft.Build.Tasks/MSBuild.xml ✅Succeeded View
xml/Microsoft.Build.Tasks/ResolveComReference.xml ✅Succeeded View
xml/Microsoft.JScript/ErrorType.xml ✅Succeeded View
xml/Microsoft.JScript/EvalErrorObject.xml ✅Succeeded View
xml/Microsoft.VisualBasic.ApplicationServices/ApplicationBase.xml ✅Succeeded View
xml/Microsoft.VisualBasic.ApplicationServices/WindowsFormsApplicationBase.xml ✅Succeeded View
xml/Microsoft.VisualBasic.MyServices/ClipboardProxy.xml ✅Succeeded View
xml/Microsoft.VisualBasic/Collection.xml ✅Succeeded View
xml/Microsoft.VisualBasic/ErrObject.xml ✅Succeeded View
xml/Microsoft.VisualBasic/Interaction.xml ✅Succeeded View
xml/Microsoft.VisualC.StlClr/GenericPair`2.xml ✅Succeeded View
xml/Microsoft.Win32/FileDialog.xml ✅Succeeded View
xml/System.Activities.Statements/CompensableActivity.xml ✅Succeeded View
xml/System.Activities.Statements/CompensationToken.xml ✅Succeeded View
xml/System.AddIn.Contract/IListContract`1.xml ✅Succeeded View
xml/System.AddIn.Hosting/AddInEnvironment.xml ✅Succeeded View
xml/System.AddIn.Hosting/AddInProcess.xml ✅Succeeded View
xml/System.AddIn.Hosting/AddInSecurityLevel.xml ✅Succeeded View
xml/System.AddIn.Hosting/AddInSegmentDirectoryNotFoundException.xml ✅Succeeded View
xml/System.AddIn.Hosting/AddInStore.xml ✅Succeeded View
xml/System.AddIn.Hosting/AddInToken.xml ✅Succeeded View
xml/System.AddIn.Pipeline/AddInAdapterAttribute.xml ✅Succeeded View
xml/System.AddIn.Pipeline/AddInBaseAttribute.xml ✅Succeeded View
xml/System.AddIn.Pipeline/AddInContractAttribute.xml ✅Succeeded View
xml/System.AddIn.Pipeline/CollectionAdapters.xml ✅Succeeded View
xml/System.AddIn.Pipeline/ContractBase.xml ✅Succeeded View
xml/System.AddIn.Pipeline/HostAdapterAttribute.xml ✅Succeeded View
xml/System.AddIn/AddInAttribute.xml ✅Succeeded View
xml/System.Collections.Generic/List`1.xml ✅Succeeded View
xml/System.Collections.Generic/Stack`1.xml ✅Succeeded View
xml/System.Collections/IEnumerable.xml ✅Succeeded View
xml/System.ComponentModel.DataAnnotations/DataType.xml ✅Succeeded View
xml/System.ComponentModel.DataAnnotations/DataTypeAttribute.xml ✅Succeeded View
xml/System.ComponentModel.DataAnnotations/DisplayFormatAttribute.xml ✅Succeeded View
xml/System.ComponentModel.DataAnnotations/RangeAttribute.xml ✅Succeeded View
xml/System.ComponentModel.DataAnnotations/ScaffoldColumnAttribute.xml ✅Succeeded View
xml/System.ComponentModel.DataAnnotations/ScaffoldTableAttribute.xml ✅Succeeded View
xml/System.ComponentModel.DataAnnotations/UIHintAttribute.xml ✅Succeeded View
xml/System.ComponentModel.DataAnnotations/ValidationException.xml ✅Succeeded View
xml/System.ComponentModel.Design.Serialization/DesignerSerializerAttribute.xml ✅Succeeded View
xml/System.ComponentModel.Design/ComponentDesigner.xml ✅Succeeded View
xml/System.ComponentModel.Design/DesignerActionPropertyItem.xml ✅Succeeded View
xml/System.ComponentModel/AsyncOperation.xml ✅Succeeded View
xml/System.ComponentModel/AsyncOperationManager.xml ✅Succeeded View
xml/System.ComponentModel/AttributeProviderAttribute.xml ✅Succeeded View
xml/System.ComponentModel/DesignerSerializationVisibilityAttribute.xml ✅Succeeded View
xml/System.ComponentModel/EditorAttribute.xml ✅Succeeded View
xml/System.ComponentModel/ICustomTypeDescriptor.xml ✅Succeeded View
xml/System.ComponentModel/IExtenderProvider.xml ✅Succeeded View

This comment lists only the first 50 files in the pull request.
For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@gewarren gewarren requested a review from mairaw January 19, 2021 20:39
@mairaw
Copy link
Contributor

mairaw commented Jan 19, 2021

No worries! That's why I left these options for later because they're a bit trickier 😉

@gewarren
Copy link
Contributor Author

No worries! That's why I left these options for later because they're a bit trickier 😉

The product team is hoping to move the source of truth to the dotnet/runtime repo in the .NET 6 timeframe. So I wanted to run the CI tool while we still had it available. I will do a smaller chunk next time.

@gewarren gewarren merged commit 7ef5638 into master Jan 19, 2021
@gewarren gewarren deleted the msdn-011321 branch January 19, 2021 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants