Skip to content

Move enum remarks to summary (part 1) #5269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 22, 2021
Merged

Conversation

gewarren
Copy link
Contributor

Contributes to #5220.

@ghost
Copy link

ghost commented Jan 21, 2021

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@opbld31

This comment has been minimized.

@opbld33

This comment has been minimized.

@opbld30

This comment has been minimized.

@opbld32
Copy link

opbld32 commented Jan 22, 2021

Docs Build status updates of commit da3a2c7:

✅ Validation status: passed

File Status Preview URL Details
xml/Microsoft.Extensions.DependencyInjection/ServiceLifetime.xml ✅Succeeded View
xml/Microsoft.Extensions.Logging.Console/LoggerColorBehavior.xml ✅Succeeded View
xml/Mono.Security.Interface/HashAlgorithmType.xml ✅Succeeded View
xml/System.Activities/ActivityInstanceState.xml ✅Succeeded View
xml/System.Drawing.Imaging/EncoderParameterValueType.xml ✅Succeeded View
xml/System.Formats.Cbor/CborReaderState.xml ✅Succeeded View
xml/System.IO/MatchType.xml ✅Succeeded View
xml/System.Net.Http/HttpVersionPolicy.xml ✅Succeeded View
xml/System.Reflection.Metadata/MetadataStreamOptions.xml ✅Succeeded View
xml/System.Reflection.Metadata/SignatureAttributes.xml ✅Succeeded View
xml/System.Reflection.Metadata/SignatureTypeCode.xml ✅Succeeded View
xml/System.Reflection.PortableExecutable/DebugDirectoryEntryType.xml ✅Succeeded View
xml/System.Reflection.PortableExecutable/PEStreamOptions.xml ✅Succeeded View
xml/System.Reflection/AssemblyHashAlgorithm.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@gewarren gewarren requested review from carlossanlop and a team January 22, 2021 01:14
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

You can :shipit: when ready.

@gewarren gewarren merged commit 2dbfa9d into dotnet:master Jan 22, 2021
@gewarren gewarren deleted the enum-remarks branch January 22, 2021 17:03
@eiriktsarpalis eiriktsarpalis added area-Infrastructure area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable. and removed area-Infrastructure labels Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants