-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Update CallerArgumentExpressionAttribute.xml #5274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added note that this is not implemented and does nothing.
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Docs Build status updates of commit d5c732d: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
This PR was sitting for too long. The feature is now implemented: dotnet/roslyn#55082 This should probably be updated now to state that it's available starting from C# 10, instead of not implemented. |
@@ -22,7 +22,7 @@ | |||
</Attribute> | |||
</Attributes> | |||
<Docs> | |||
<summary>Allows capturing of the expressions passed to a method.</summary> | |||
<summary>Allows capturing of the expressions passed to a method. NOTE: Is not yet implemented in C# compiler and does nothing.</summary> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<summary>Allows capturing of the expressions passed to a method. NOTE: Is not yet implemented in C# compiler and does nothing.</summary> | |
<summary>Indicates that a parameter captures the expression passed for another parameter as a string. This functionality is available starting in C# 10.</summary> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does my suggestion make sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll merge this now and submit my suggestions in a separate PR.
@@ -22,7 +22,7 @@ | |||
</Attribute> | |||
</Attributes> | |||
<Docs> | |||
<summary>Allows capturing of the expressions passed to a method.</summary> | |||
<summary>Allows capturing of the expressions passed to a method. NOTE: Is not yet implemented in C# compiler and does nothing.</summary> | |||
<remarks>To be added.</remarks> | |||
</Docs> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
</Docs> | |
<related type="Article" href="/dotnet/csharp/language-reference/proposals/csharp-10.0/caller-argument-expression">C# CallerArgumentExpression proposal</related> | |
</Docs> |
Summary
Added note that this is not implemented and does nothing.
Fixes #5153