Skip to content

Conversation

NetMage
Copy link
Contributor

@NetMage NetMage commented Jan 22, 2021

Summary

Added note that this is not implemented and does nothing.

Fixes #5153

Added note that this is not implemented and does nothing.
@ghost
Copy link

ghost commented Jan 22, 2021

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@opbld33
Copy link

opbld33 commented Jan 22, 2021

Docs Build status updates of commit d5c732d:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Runtime.CompilerServices/CallerArgumentExpressionAttribute.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@eiriktsarpalis
Copy link
Member

cc @buyaa-n @joperezr @krwq

Base automatically changed from master to main March 5, 2021 20:52
@MSDN-WhiteKnight
Copy link
Contributor

This PR was sitting for too long. The feature is now implemented: dotnet/roslyn#55082 This should probably be updated now to state that it's available starting from C# 10, instead of not implemented.

@@ -22,7 +22,7 @@
</Attribute>
</Attributes>
<Docs>
<summary>Allows capturing of the expressions passed to a method.</summary>
<summary>Allows capturing of the expressions passed to a method. NOTE: Is not yet implemented in C# compiler and does nothing.</summary>
Copy link
Contributor

@gewarren gewarren Sep 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<summary>Allows capturing of the expressions passed to a method. NOTE: Is not yet implemented in C# compiler and does nothing.</summary>
<summary>Indicates that a parameter captures the expression passed for another parameter as a string. This functionality is available starting in C# 10.</summary>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does my suggestion make sense?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this now and submit my suggestions in a separate PR.

@@ -22,7 +22,7 @@
</Attribute>
</Attributes>
<Docs>
<summary>Allows capturing of the expressions passed to a method.</summary>
<summary>Allows capturing of the expressions passed to a method. NOTE: Is not yet implemented in C# compiler and does nothing.</summary>
<remarks>To be added.</remarks>
</Docs>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
</Docs>
<related type="Article" href="/dotnet/csharp/language-reference/proposals/csharp-10.0/caller-argument-expression">C# CallerArgumentExpression proposal</related>
</Docs>

@gewarren gewarren merged commit f596824 into dotnet:main Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CallerArgumentExpressionAttribute documentation should document that it DOES NOTHING
6 participants