Skip to content

Conversation

Tanya-Solyanik
Copy link
Contributor

Summary

  1. removed redundant namespace names for included namespaces, i.e. System.Windows.Forms
  2. removed allocations of event handler delegates when adding event handlers
  3. re-formatted a couple of long lines.

This code builds and runs on .NET Core and .NET Framework

@Tanya-Solyanik Tanya-Solyanik added the area-WinForms Issues or PRs that relate to WinForms. label Feb 2, 2021
@opbld34
Copy link

opbld34 commented Feb 2, 2021

Docs Build status updates of commit 6a408be:

✅ Validation status: passed

File Status Preview URL Details
samples/snippets/csharp/VS_Snippets_Winforms/System.Windows.Forms.Control.DoDragDrop/CS/form1.cs ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

1. removed redundant namespace names for included namespaces, i.e. System.Windows.Forms
2. removed allocations of event handler delegates when adding event handlers
3. re-formatted a couple of long lines.
4. ensured consisten braces placement - on new lines
5. removed blank lines

This code builds and runs   on .NET Core and .NET Framework
@opbld34
Copy link

opbld34 commented Feb 2, 2021

Docs Build status updates of commit 380a1cc:

✅ Validation status: passed

File Status Preview URL Details
samples/snippets/csharp/VS_Snippets_Winforms/System.Windows.Forms.Control.DoDragDrop/CS/form1.cs ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

1. removed redandant namespace anmes
2. removed some blank lines
@opbld33
Copy link

opbld33 commented Feb 2, 2021

Docs Build status updates of commit 5f4a2ae:

✅ Validation status: passed

File Status Preview URL Details
samples/snippets/csharp/VS_Snippets_Winforms/System.Windows.Forms.Control.DoDragDrop/CS/form1.cs ✅Succeeded View
samples/snippets/visualbasic/VS_Snippets_Winforms/System.Windows.Forms.Control.DoDragDrop/VB/form1.vb ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Base automatically changed from master to main March 5, 2021 20:52
@gewarren gewarren requested a review from a team as a code owner March 5, 2021 20:52
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gewarren gewarren merged commit 8f52227 into main Mar 10, 2021
@gewarren gewarren deleted the Tanya-Solyanik-patch-1 branch March 10, 2021 20:15
@Tanya-Solyanik
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-WinForms Issues or PRs that relate to WinForms.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants