Skip to content

Fix docs #6633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix docs #6633

wants to merge 2 commits into from

Conversation

john-h-k
Copy link
Contributor

@john-h-k john-h-k commented Apr 11, 2021 •
edited
Loading

They were just wrong before

@john-h-k
Fix docs
59f9e72 
They were just wrong before
@opbld32

This comment was marked as outdated.

Sign in to view
gewarren
gewarren reviewed Apr 22, 2021
View reviewed changes
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@WhiteBlackGoose
Copy link
Contributor

Why did this PR die?

@BillWagner
Copy link
Member

@WhiteBlackGoose It looks like the original author didn't accept the change or respond to the feedback.

@gewarren Do you want to accept your suggestions and merge this?

@opbld34

This comment was marked as outdated.

Sign in to view
@gewarren gewarren closed this Jul 26, 2021
@gewarren gewarren reopened this Jul 26, 2021
@opbld34

This comment was marked as outdated.

Sign in to view
@fenxu fenxu closed this Jul 27, 2021
@fenxu fenxu reopened this Jul 27, 2021
@opbld30
Copy link

opbld30 commented Jul 27, 2021

Docs Build status updates of commit 772c395:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Runtime.CompilerServices/Unsafe.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@MSDN-WhiteKnight
Copy link
Contributor

This PR conflicted with #8097 Is it still needed with changes in that PR?

@gewarren
Copy link
Contributor

@GrabYourPitchforks Should the As<T> comments be changed to use "reinterpret" instead of "cast" as in this PR?

@ericstj ericstj requested review from GrabYourPitchforks and removed request for buyaa-n March 24, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gewarren gewarren gewarren left review comments

@joperezr joperezr Awaiting requested review from joperezr

@krwq krwq Awaiting requested review from krwq

@GrabYourPitchforks GrabYourPitchforks Awaiting requested review from GrabYourPitchforks

At least 1 approving review is required to merge this pull request.

Assignees

@michaelgsharp michaelgsharp

Labels

area-System.Runtime.CompilerServices

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@john-h-k @opbld32 @WhiteBlackGoose @BillWagner @opbld34 @opbld30 @MSDN-WhiteKnight @gewarren @fenxu @michaelgsharp