-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Port System.Text.Json triple slash to docs #7094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tagging subscribers to this area: @eiriktsarpalis, @layomia Issue DetailsFound with DocsPortingTool
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. This should address the final batch of APIs that were added in RC1.
Fixes dotnet/runtime#54862
Actually, not yet. There are some more APIs in my report that do not have triple slash. Mostly from System.Text.Json.Nodes. There's the possibility that the DocsPortingTool is unable to match the DocId of those APIs. Could you help me figure out if it's due to lack of docs or a bug in the tool? @eiriktsarpalis |
<Docs> | ||
<summary>To be added.</summary> | ||
<value>To be added.</value> | ||
<summary>Gets the captured span from the input string.</summary> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
xml/System.Text.Json.Serialization.Metadata/JsonMetadataServices.xml
Outdated
Show resolved
Hide resolved
xml/System.Text.Json.Serialization.Metadata/JsonObjectInfoValues`1.xml
Outdated
Show resolved
Hide resolved
xml/System.Text.Json.Serialization.Metadata/JsonObjectInfoValues`1.xml
Outdated
Show resolved
Hide resolved
xml/System.Text.Json.Serialization.Metadata/JsonObjectInfoValues`1.xml
Outdated
Show resolved
Hide resolved
xml/System.Text.Json.Serialization.Metadata/JsonObjectInfoValues`1.xml
Outdated
Show resolved
Hide resolved
@carlossanlop shouldn't this also be ported to |
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@eiriktsarpalis no, |
Docs Build status updates of commit f2f4e78: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Found with DocsPortingTool.
Also included a System.Text.RegularExpressions port (by mistake, but let's get it merged). @tannergooding @pgovind
@gewarren I'm targeting the net6-rc1 branch.