Skip to content

Conversation

carlossanlop
Copy link
Contributor

@carlossanlop carlossanlop commented Sep 3, 2021

Found with DocsPortingTool.

Also included a System.Text.RegularExpressions port (by mistake, but let's get it merged). @tannergooding @pgovind

@gewarren I'm targeting the net6-rc1 branch.

@ghost
Copy link

ghost commented Sep 3, 2021

Tagging subscribers to this area: @eiriktsarpalis, @layomia
See info in area-owners.md if you want to be subscribed.

Issue Details

Found with DocsPortingTool

Author: carlossanlop
Assignees: carlossanlop
Labels:

area-System.Text.Json

Milestone: -

@gewarren

This comment has been minimized.

@gewarren

This comment has been minimized.

Copy link
Member

@eiriktsarpalis eiriktsarpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This should address the final batch of APIs that were added in RC1.

Fixes dotnet/runtime#54862

@carlossanlop
Copy link
Contributor Author

Thanks. This should address the final batch of APIs that were added in RC1.

Actually, not yet. There are some more APIs in my report that do not have triple slash. Mostly from System.Text.Json.Nodes.

There's the possibility that the DocsPortingTool is unable to match the DocId of those APIs. Could you help me figure out if it's due to lack of docs or a bug in the tool? @eiriktsarpalis

<Docs>
<summary>To be added.</summary>
<value>To be added.</value>
<summary>Gets the captured span from the input string.</summary>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eiriktsarpalis
Copy link
Member

@carlossanlop shouldn't this also be ported to main?

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@carlossanlop
Copy link
Contributor Author

@eiriktsarpalis no, main is not yet targeting RC1. The latest APIs only exist in the net6-rc1 branch, which is the one we are currently using for the last 6.0 docs, and we will eventually merge that branch into main.

@opbld32
Copy link

opbld32 commented Sep 8, 2021

Docs Build status updates of commit f2f4e78:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Text.Json.Serialization.Metadata/JsonMetadataServices.xml ✅Succeeded View
xml/System.Text.Json.Serialization.Metadata/JsonObjectInfoValues`1.xml ✅Succeeded View
xml/System.Text.Json.Serialization.Metadata/JsonParameterInfoValues.xml ✅Succeeded View
xml/System.Text.Json.Serialization/JsonConverter`1.xml ✅Succeeded View
xml/System.Text.Json/JsonSerializer.xml ✅Succeeded View
xml/System.Text.RegularExpressions/Capture.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@carlossanlop carlossanlop merged commit 0300161 into dotnet:net6-rc1 Sep 8, 2021
@carlossanlop carlossanlop deleted the upd.json branch September 8, 2021 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants