Port System.Security.Cryptography.Xml triple slash to docs #7096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossanlop
added
the
area-System.Security
carlossanlop
requested review from
GrabYourPitchforks and
bartonjs
as code owners
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks Issue DetailsPorted with DocsPortingTool. @gewarren targeting the net6-rc1 branch.
|
carlossanlop
commented
Sep 3, 2021
| <param name="strUri">The Uniform Resource Identifier (URI) of the information to be referenced by the new instance of <see cref="T:System.Security.Cryptography.Xml.KeyInfoRetrievalMethod" />.</param> | ||
| <param name="typeName">The URI that describes the type of data to retrieve.</param> | ||
| <param name="strType">To be added.</param> | ||
| <param name="strType">The URI that describes the type of data to retrieve.</param> |
There was a problem hiding this comment.
@bartonjs @GrabYourPitchforks this was detected by DocsPortingTool as an argument that got renamed, and had to manually choose which was the old argument name. I am not entirely sure if strType was typeName or strUri, but it made more sense to me to choose the description from typeName. Was this the right choice?
There was a problem hiding this comment.
It's called typeName in both .NET Framework and .NET (nee Core), for some reason it was strType in Xamarin.
This comment has been minimized.
This comment has been minimized.
gewarren
approved these changes
Sep 4, 2021
xml/System.Security.Cryptography.Xml/CryptoSignedXmlRecursionException.xml
Outdated
Show resolved
Hide resolved
xml/System.Security.Cryptography.Xml/CryptoSignedXmlRecursionException.xml
Outdated
Show resolved
Hide resolved
xml/System.Security.Cryptography.Xml/CryptoSignedXmlRecursionException.xml
Outdated
Show resolved
Hide resolved
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
…xception.xml Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
bartonjs
approved these changes
Sep 8, 2021
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported with DocsPortingTool.
@gewarren targeting the net6-rc1 branch.