-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Port System.Runtime.Versioning.RequiresPreviewFeaturesAttribute triple slash to docs #7102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
xml/System.Runtime.Versioning/RequiresPreviewFeaturesAttribute.xml
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
<Docs> | ||
<summary>To be added.</summary> | ||
<summary>This attribute declares an API to be Preview and allows call sites to be flagged with a diagnostic indicating Preview API usage. Authors can use this attribute to ship Preview features in their assemblies.</summary> | ||
<remarks>To be added.</remarks> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Suggestion removed, I placed this in the wrong line. See the next line]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: The link is not active yet, but will be by the time we ship.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to type="Article"
? Also, who is writing the documentation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pgovind @tannergooding are you going to take care of this document? It should be up before we ship this: https://aka.ms/dotnet-warnings/preview-features
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added the preview features properties to the MSBuild reference: https://docs.microsoft.com/en-us/dotnet/core/project-sdk/msbuild-props#enablepreviewfeatures. But I'll also plan to write a conceptual article.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
xml/System.Runtime.Versioning/RequiresPreviewFeaturesAttribute.xml
Outdated
Show resolved
Hide resolved
xml/System.Runtime.Versioning/RequiresPreviewFeaturesAttribute.xml
Outdated
Show resolved
Hide resolved
xml/System.Runtime.Versioning/RequiresPreviewFeaturesAttribute.xml
Outdated
Show resolved
Hide resolved
<Docs> | ||
<summary>To be added.</summary> | ||
<summary>This attribute declares an API to be Preview and allows call sites to be flagged with a diagnostic indicating Preview API usage. Authors can use this attribute to ship Preview features in their assemblies.</summary> | ||
<remarks>To be added.</remarks> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to type="Article"
? Also, who is writing the documentation?
xml/System.Runtime.Versioning/RequiresPreviewFeaturesAttribute.xml
Outdated
Show resolved
Hide resolved
xml/System.Runtime.Versioning/RequiresPreviewFeaturesAttribute.xml
Outdated
Show resolved
Hide resolved
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Docs Build status updates of commit c142d84: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
The docs team is my understanding, with me, @terrajobst and @jeffhandley helping. There's a design spec here: https://github.com/dotnet/designs/blob/main/accepted/2021/preview-features/preview-features.md. The |
Ported with DocsPortingTool.
Targeting the net6-rc1 branch.