Skip to content

Conversation

carlossanlop
Copy link
Contributor

Ported using DocsPortingTool.

Found a small bunch of docs in System.Net that could be ported.

@carlossanlop carlossanlop requested a review from a team September 3, 2021 21:19
@carlossanlop carlossanlop self-assigned this Sep 3, 2021
@ghost
Copy link

ghost commented Sep 3, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Ported using DocsPortingTool.

Found a small bunch of docs in System.Net that could be ported.

Author: carlossanlop
Assignees: carlossanlop
Labels:

area-System.Net

Milestone: -

<param name="offset">The location in <paramref name="buffer" /> to begin storing the data.</param>
<param name="size">The number of bytes to read from the <see cref="T:System.Net.Sockets.NetworkStream" />.</param>
<param name="count">To be added.</param>
<param name="count">The number of bytes to read from the <see cref="T:System.Net.Sockets.NetworkStream" />.</param>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads exactly the same as the size parameter. Same in the other 5 places below.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, I see this is because the parameter name changed. I didn't see a breaking change come through for these name changes.

@gewarren

This comment has been minimized.

@opbld32
Copy link

opbld32 commented Sep 8, 2021

Docs Build status updates of commit aa02815:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Net.Http/SocketsHttpConnectionContext.xml ✅Succeeded View
xml/System.Net.Http/SocketsHttpHandler.xml ✅Succeeded View
xml/System.Net.Http/SocketsHttpPlaintextStreamFilterContext.xml ✅Succeeded View
xml/System.Net.Security/NegotiateStream.xml ✅Succeeded View
xml/System.Net.Security/SslStream.xml ✅Succeeded View
xml/System.Net.Sockets/NetworkStream.xml ✅Succeeded View
xml/System.Net/IPAddress.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@carlossanlop carlossanlop merged commit 5f12b27 into dotnet:net6-rc1 Sep 8, 2021
@carlossanlop carlossanlop deleted the upd.net branch September 8, 2021 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants