Skip to content

Conversation

AaronRobinsonMSFT
Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT commented Sep 3, 2021

@gewarren

This comment has been minimized.

Copy link
Contributor

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for taking care of this, @AaronRobinsonMSFT .

@gewarren
Copy link
Contributor

gewarren commented Sep 4, 2021

Docs Build status updates of commit a116e28:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Runtime.InteropServices/Architecture.xml ✅Succeeded View
xml/System.Runtime.InteropServices/CollectionsMarshal.xml ✅Succeeded View
xml/System.Runtime.InteropServices/MemoryMarshal.xml ✅Succeeded View
xml/System.Runtime.InteropServices/PosixSignalContext.xml ✅Succeeded View
xml/System.Runtime.InteropServices/UnmanagedCallConvAttribute.xml ✅Succeeded View
xml/ns-System.Runtime.InteropServices.ObjectiveC.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

<Parameter Name="unhandledExceptionPropagationHandler" Type="System.Runtime.InteropServices.ObjectiveC.ObjectiveCMarshal+UnhandledExceptionPropagationHandler" />
</Parameters>
<Docs>
<param name="beginEndCallback">To be added.</param>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gewarren @joelmartinez the DocId of this API is really unconventional. This prevented the DocsPortingTool from matching documentation from the IntelliSense xml files and port it.

The IntelliSense xml file looks even worse: M:System.Runtime.InteropServices.ObjectiveC.ObjectiveCMarshal.Initialize(,,,System.Runtime.InteropServices.ObjectiveC.ObjectiveCMarshal.UnhandledExceptionPropagationHandler)

Just wanted you to know in case you see issues with these ObjectiveC related APIs.

@gewarren
Copy link
Contributor

gewarren commented Sep 4, 2021

Docs Build status updates of commit 21f43d3:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Runtime.InteropServices.ObjectiveC/ObjectiveCMarshal+UnhandledExceptionPropagationHandler.xml ✅Succeeded View
xml/System.Runtime.InteropServices.ObjectiveC/ObjectiveCMarshal.xml ✅Succeeded View
xml/System.Runtime.InteropServices/Architecture.xml ✅Succeeded View
xml/System.Runtime.InteropServices/CollectionsMarshal.xml ✅Succeeded View
xml/System.Runtime.InteropServices/MemoryMarshal.xml ✅Succeeded View
xml/System.Runtime.InteropServices/PosixSignalContext.xml ✅Succeeded View
xml/System.Runtime.InteropServices/UnmanagedCallConvAttribute.xml ✅Succeeded View
xml/ns-System.Runtime.InteropServices.ObjectiveC.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@carlossanlop carlossanlop merged commit c5cf285 into dotnet:net6-rc1 Sep 6, 2021
@AaronRobinsonMSFT AaronRobinsonMSFT deleted the update_interop2 branch September 6, 2021 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants