-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Adding basic doc comments for System.Math.Sign, System.Math.SinCos, and System.MathF.SinCos #7189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…nd System.MathF.SinCos
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@gewarren first time I see the CI failure "Snippets 5000 / build (pull_request)". The error is:
The example files already existed before. Should we do something about this or can we ignore it? |
@carlossanlop You'll need to add a simple project file to the folder, similar to https://github.com/dotnet/dotnet-api-docs/blob/main/snippets/System.Text/Rune/csharp/RuneSamples.csproj. This is a new requirement to ensure that code samples build correctly. It's already caught some bugs :) |
@tannergooding please accept my PR tannergooding#5 I would've pushed directly to this PR branch, but I don't have permission to edit someone's |
Add required csproj files
Note: the csproj is targeting |
This comment has been minimized.
This comment has been minimized.
samples/snippets/csharp/VS_Snippets_CLR_System/system.Math.SinCos/CS/sincos.cs
Outdated
Show resolved
Hide resolved
We can confirm the feature works 😄 @gewarren |
Docs Build status updates of commit f280235: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
This resolves dotnet/runtime#54882