Skip to content

Conversation

tannergooding
Copy link
Member

This resolves dotnet/runtime#54882

@tannergooding tannergooding requested a review from a team as a code owner September 15, 2021 15:37
@ghost ghost added the area-System.Runtime label Sep 15, 2021
@opbld33

This comment has been minimized.

@opbld34

This comment has been minimized.

@carlossanlop
Copy link
Contributor

@gewarren first time I see the CI failure "Snippets 5000 / build (pull_request)". The error is:

Error: 😵 Project missing. A project (and optionally a solution file) must be in this directory or one of the parent directories to validate and build this code.
Error: 😵 Project missing. A project (and optionally a solution file) must be in this directory or one of the parent directories to validate and build this code.
Error: Process completed with exit code 1.

The example files already existed before. Should we do something about this or can we ignore it?

@gewarren
Copy link
Contributor

@gewarren first time I see the CI failure "Snippets 5000 / build (pull_request)". The error is:

Error: 😵 Project missing. A project (and optionally a solution file) must be in this directory or one of the parent directories to validate and build this code.
Error: 😵 Project missing. A project (and optionally a solution file) must be in this directory or one of the parent directories to validate and build this code.
Error: Process completed with exit code 1.

The example files already existed before. Should we do something about this or can we ignore it?

@carlossanlop You'll need to add a simple project file to the folder, similar to https://github.com/dotnet/dotnet-api-docs/blob/main/snippets/System.Text/Rune/csharp/RuneSamples.csproj. This is a new requirement to ensure that code samples build correctly. It's already caught some bugs :)

@carlossanlop
Copy link
Contributor

@tannergooding please accept my PR tannergooding#5

I would've pushed directly to this PR branch, but I don't have permission to edit someone's main branch 😞

@carlossanlop
Copy link
Contributor

Note: the csproj is targeting net6.0. Let's hope it builds. 🤞🏼

@opbld33

This comment has been minimized.

@carlossanlop
Copy link
Contributor

It's already caught some bugs :)

We can confirm the feature works 😄 @gewarren

@opbld33
Copy link

opbld33 commented Sep 15, 2021

Docs Build status updates of commit f280235:

✅ Validation status: passed

File Status Preview URL Details
samples/snippets/csharp/VS_Snippets_CLR/math.sign/CS/sign.cs ✅Succeeded View
samples/snippets/csharp/VS_Snippets_CLR/math.sign/System.Math.Sign.csproj ✅Succeeded
samples/snippets/csharp/VS_Snippets_CLR_System/system.Math.SinCos/CS/sincos.cs ✅Succeeded View
samples/snippets/csharp/VS_Snippets_CLR_System/system.Math.SinCos/System.Math.SinCos.csproj ✅Succeeded
xml/System/Math.xml ✅Succeeded View
xml/System/MathF.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@carlossanlop carlossanlop merged commit e818712 into dotnet:main Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

System - Undoc 6.0 APIs

5 participants