Skip to content

Improve CallerArgumentExpressionAttribute #7338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 1, 2021
Merged

Improve CallerArgumentExpressionAttribute #7338

merged 3 commits into from
Nov 1, 2021

Conversation

gewarren
Copy link
Contributor

No description provided.

@gewarren gewarren requested a review from a team as a code owner October 29, 2021 19:20
@opbld34
Copy link

opbld34 commented Oct 29, 2021

Docs Build status updates of commit b7199aa:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Runtime.CompilerServices/CallerArgumentExpressionAttribute.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@@ -23,7 +23,7 @@
</Attribute>
</Attributes>
<Docs>
<summary>Allows capturing of the expressions passed to a method. NOTE: Is not yet implemented in C# compiler and does nothing.</summary>
<summary>Indicates that a parameter captures the expression passed for another parameter as a string. NOTE: This attribute is not yet implemented in the C# compiler and does nothing.</summary>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: Isn't the NOTE: part should go into standard > [!NOTE] section? But not sure if the inline one could get more attention, up to you, I am OK as is

@opbld30
Copy link

opbld30 commented Nov 1, 2021

Docs Build status updates of commit f65a5f5:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Runtime.CompilerServices/CallerArgumentExpressionAttribute.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Copy link
Contributor

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@opbld34
Copy link

opbld34 commented Nov 1, 2021

Docs Build status updates of commit 8394870:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Runtime.CompilerServices/CallerArgumentExpressionAttribute.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@gewarren gewarren merged commit 498be16 into main Nov 1, 2021
@gewarren gewarren deleted the gewarren-patch-5 branch November 1, 2021 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants