Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ArgumentNullException to AddProvider #7360

Merged
merged 1 commit into from Nov 9, 2021
Merged

Add ArgumentNullException to AddProvider #7360

merged 1 commit into from Nov 9, 2021

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Nov 6, 2021

Contributes to dotnet/docs#26780.

@ghost
Copy link

ghost commented Nov 6, 2021

Tagging subscribers to this area: @maryamariyan
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to dotnet/docs#26780.

Author: gewarren
Assignees: -
Labels:

area-Extensions-Logging

Milestone: -

@opbld31
Copy link

opbld31 commented Nov 6, 2021

Docs Build status updates of commit 037d416:

✅ Validation status: passed

File Status Preview URL Details
xml/Microsoft.Extensions.Logging/LoggerFactory.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@@ -29,7 +29,7 @@
</Interface>
</Interfaces>
<Docs>
<summary>Produces instances of <see cref="T:Microsoft.Extensions.Logging.ILogger" /> classes based on the given providers.</summary>
<summary>Produces instances of <see cref="T:Microsoft.Extensions.Logging.ILogger" /> classes based on the specified providers.</summary>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gewarren @carlossanlop - for some reason I thought the triple-slash doc comments in dotnet/runtime were now the "master". Shouldn't we be updating them instead?

https://github.com/dotnet/runtime/blob/a8ac67ae5373dce4d337012d2e8c875d32ffa638/src/libraries/Microsoft.Extensions.Logging/src/LoggerFactory.cs#L12

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are not yet. We have only moved over 3 projects and we stopped because the porting tool has some issues. However we will try and make it the main story for .NET 7

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the plan to port these changes to the triple-slash doc comments in the code?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should with the doc porting tool once that is ready.

@gewarren gewarren merged commit ed13070 into main Nov 9, 2021
@gewarren gewarren deleted the gewarren-patch-7 branch November 9, 2021 00:09
BillWagner pushed a commit that referenced this pull request Nov 9, 2021
* Update IConfiguration.xml

Add a additional remark paragraph

* Mention C# native integers in IntPtr/UIntPtr docs (#7364)

* Update IntPtr.xml

* Update UIntPtr.xml

* Fixed identation (#7365)

* Update xml/Microsoft.Extensions.Configuration/IConfiguration.xml

The grammar is resolved

Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>

* Update obsoletion note in summary (#7359)

* Update SecureString.xml (#7344)

Obviously, those duplicate `SecureStringToCoTaskMemUnicode` should be `SecureStringToGlobalAllocUnicode`

* Add exception (#7360)

* add new exceptions (#7367)

Co-authored-by: Artur <58558002+Narick9@users.noreply.github.com>
Co-authored-by: MSDN.WhiteKnight <35516665+MSDN-WhiteKnight@users.noreply.github.com>
Co-authored-by: Thiago Viana Avelar De Souza <thide2001@gmail.com>
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Co-authored-by: tangentyh <tangentyh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants