Skip to content

Conversation

MSDN-WhiteKnight
Copy link
Contributor

Add examples that generate different shapes of method signatures with BlobEncoder.

Note: if you want to verify that encoded signatures are valid, you can use this sample which does similar things, but produce a complete assembly that could be inspected with ildasm. I'm not adding a complete sample here, because MetadataBuilder already has it.

@MSDN-WhiteKnight MSDN-WhiteKnight requested a review from a team as a code owner February 2, 2022 06:09
@ghost
Copy link

ghost commented Feb 2, 2022

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@opbld34
Copy link

opbld34 commented Feb 2, 2022

Docs Build status updates of commit 8638262:

✅ Validation status: passed

File Status Preview URL Details
snippets/csharp/System.Reflection.Metadata.Ecma335/BlobEncoder/MethodSignature/MethodSignatureSnippets.cs ✅Succeeded View
snippets/csharp/System.Reflection.Metadata.Ecma335/BlobEncoder/MethodSignature/MethodSignatureSnippets.csproj ✅Succeeded
snippets/csharp/System.Reflection.Metadata.Ecma335/BlobEncoder/MethodSignature/Program.cs ✅Succeeded
xml/System.Reflection.Metadata.Ecma335/BlobEncoder.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@opbld30
Copy link

opbld30 commented Feb 3, 2022

Docs Build status updates of commit 5f5b40c:

✅ Validation status: passed

File Status Preview URL Details
snippets/csharp/System.Reflection.Metadata.Ecma335/BlobEncoder/MethodSignature/MethodSignatureSnippets.cs ✅Succeeded View
snippets/csharp/System.Reflection.Metadata.Ecma335/BlobEncoder/MethodSignature/MethodSignatureSnippets.csproj ✅Succeeded
snippets/csharp/System.Reflection.Metadata.Ecma335/BlobEncoder/MethodSignature/Program.cs ✅Succeeded
xml/System.Reflection.Metadata.Ecma335/BlobEncoder.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Copy link
Contributor

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@buyaa-n buyaa-n merged commit 0b39a8f into dotnet:main Feb 23, 2022
@MSDN-WhiteKnight MSDN-WhiteKnight deleted the method-signature branch February 23, 2022 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants