Skip to content

Conversation

brenoafb
Copy link
Contributor

Summary

Add F# examples for documention on System.Strings.IsNullOrEmpty

@brenoafb brenoafb requested a review from a team as a code owner February 18, 2022 19:49
@ghost ghost added the area-System.Runtime label Feb 18, 2022
@opbld31
Copy link

opbld31 commented Feb 18, 2022

Docs Build status updates of commit 7e63510:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/System/String.xml ⚠️Warning View Details
snippets/fsharp/System/String/IsNullOrEmpty/NullString1.fs ✅Succeeded View
snippets/fsharp/System/String/IsNullOrEmpty/inoe.fs ✅Succeeded View
snippets/fsharp/System/String/IsNullOrEmpty/isnullorempty1.fs ✅Succeeded

xml/System/String.xml

  • Line 0, Column 0: [Warning: invalid-code] The code snippet "~/snippets/fsharp/System/String/IsNullOrEmpty/isnullorempty1.cs" could not be found.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@opbld30
Copy link

opbld30 commented Feb 18, 2022

Docs Build status updates of commit f7567d5:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/System/String.xml ⚠️Warning View Details
snippets/fsharp/System/String/IsNullOrEmpty/IsNullOrEmpty.fsproj ✅Succeeded
snippets/fsharp/System/String/IsNullOrEmpty/NullString1.fs ✅Succeeded View
snippets/fsharp/System/String/IsNullOrEmpty/NullString2.fs ✅Succeeded View
snippets/fsharp/System/String/IsNullOrEmpty/inoe.fs ✅Succeeded View
snippets/fsharp/System/String/IsNullOrEmpty/isnullorempty1.fs ✅Succeeded

xml/System/String.xml

  • Line 0, Column 0: [Warning: invalid-code] The code snippet "~/snippets/fsharp/System/String/IsNullOrEmpty/isnullorempty1.cs" could not be found.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Add project+modules for F# String.IsNullOrEmpty snippets

Fix F# snippet link
@brenoafb brenoafb force-pushed the string-isemptyornull-fsharp branch from f7567d5 to 027617d Compare February 19, 2022 23:10
@opbld30
Copy link

opbld30 commented Feb 19, 2022

Docs Build status updates of commit 027617d:

✅ Validation status: passed

File Status Preview URL Details
snippets/fsharp/System/String/IsNullOrEmpty/IsNullOrEmpty.fsproj ✅Succeeded
snippets/fsharp/System/String/IsNullOrEmpty/NullString1.fs ✅Succeeded View
snippets/fsharp/System/String/IsNullOrEmpty/NullString2.fs ✅Succeeded View
snippets/fsharp/System/String/IsNullOrEmpty/inoe.fs ✅Succeeded View
snippets/fsharp/System/String/IsNullOrEmpty/isnullorempty1.fs ✅Succeeded View
xml/System/String.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these @brenoafb

I've reviewed the changes, and I'll :shipit: now.

@BillWagner BillWagner merged commit 1dcd3df into dotnet:main Feb 22, 2022
@brenoafb brenoafb deleted the string-isemptyornull-fsharp branch February 25, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants