Skip to content

Update code to match comment #7938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2022
Merged

Update code to match comment #7938

merged 1 commit into from
May 12, 2022

Conversation

3141592654
Copy link
Contributor

Right now, the example referred to in "The following example sets MaxReceivedMessageSize to 1,000,000 bytes" sets MaxReceivedMessageSize to 131,072 bytes.

@opbld30
Copy link

opbld30 commented Apr 8, 2022

Docs Build status updates of commit 42ca618:

✅ Validation status: passed

File Status Preview URL Details
xml/System.ServiceModel/BasicHttpBinding.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@3141592654
Copy link
Contributor Author

@mconnew Can I get a review on this?

@mconnew
Copy link
Member

mconnew commented May 11, 2022

This change is correct based on the source documentation xml. I'm having difficulty finding the actual documentation page though. Clicking the MaxReceivedMessageSize property in the list of properties takes me to the documentation for the base class HttpBindingBase.

@3141592654
Copy link
Contributor Author

...I'm having difficulty finding the actual documentation page though...

https://docs.microsoft.com/en-us/dotnet/api/system.servicemodel.basichttpbinding.maxreceivedmessagesize?view=netframework-4.0

If you go to the Preview URL and set the Version to ".NET Framework 4.0", you will see the page. (This bit of the documentation is a little old).

@mconnew
Copy link
Member

mconnew commented May 12, 2022

@3141592654, thanks. I didn't realize that the class hierarchy changed between 4.0 and 4.5 as it was an in-place replacement, and I wouldn't have expected moving a property to a base class would have been binary compatible. Thanks.

@gewarren gewarren merged commit 134a731 into dotnet:main May 12, 2022
@3141592654 3141592654 deleted the FixTypo branch May 12, 2022 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants