Skip to content

RunAsync waits for hosted services to stop #7954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2022
Merged

RunAsync waits for hosted services to stop #7954

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions xml/Microsoft.Extensions.Hosting/HostingAbstractionsHostExtensions.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
</Parameters>
<Docs>
<param name="host">The <see cref="T:Microsoft.Extensions.Hosting.IHost" /> to run.</param>
<summary>Runs an application and blocks the calling thread until host shutdown.</summary>
<summary>Runs an application and blocks the calling thread until host shutdown is triggered and all <see cref="T:Microsoft.Extensions.Hosting.IHostedService" /> instances are stopped.</summary>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue you linked is for RunAsync not Run. Let's only update the doc over RunAsync.

Do you have a code repro showing the same holds true for Run?

cc @eerhardt

Copy link
Contributor Author

@pedrobsaila pedrobsaila Apr 19, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run is just a synchronous wrapper around RunAsync

https://github.com/dotnet/runtime/blob/2be87c9c976c0cd21b66ea12ae406a559aacaac0/src/libraries/Microsoft.Extensions.Hosting.Abstractions/src/HostingAbstractionsHostExtensions.cs#L44-L51

<remarks>To be added.</remarks>
</Docs>
</Member>
Expand Down Expand Up @@ -87,7 +87,7 @@
<Docs>
<param name="host">The <see cref="T:Microsoft.Extensions.Hosting.IHost" /> to run.</param>
<param name="token">The token to trigger shutdown.</param>
<summary>Runs an application and returns a Task that only completes when the token is triggered or shutdown is triggered.</summary>
<summary>Runs an application and returns a Task that only completes when the token is triggered or shutdown is triggered and all <see cref="T:Microsoft.Extensions.Hosting.IHostedService" /> instances are stopped.</summary>
<returns>The <see cref="T:System.Threading.Tasks.Task" /> that represents the asynchronous operation.</returns>
<remarks>To be added.</remarks>
</Docs>
Expand Down