Update baselines for mdoc 5.8.9 #7995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build.Reason:Manual by Min Huang Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=287608&view=results source_repo.branch:master source_repo.url:https://apidrop.visualstudio.com/_git/binaries
Build.Reason:Manual by Min Huang Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=287618&view=results source_repo.branch:master source_repo.url:https://apidrop.visualstudio.com/_git/binaries
Build.Reason:Manual by Min Huang Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=287796&view=results source_repo.branch:master source_repo.url:https://apidrop.visualstudio.com/_git/binaries
Build.Reason:Manual by Min Huang Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=287827&view=results source_repo.branch:master source_repo.url:https://apidrop.visualstudio.com/_git/binaries
gewarren
requested review from
RussKie,
merriemcgaw,
Rick-Anderson,
AaronRobinsonMSFT,
jkoritzinsky,
ajcvickers,
David-Engel,
JRahnama and
a team
as code owners
ghost
added
the
area-Meta
BillWagner
reviewed
Apr 26, 2022
| @@ -1,10 +1,10 @@ | |||
| <Type Name="ObjectiveCMarshal+UnhandledExceptionPropagationHandler" FullName="System.Runtime.InteropServices.ObjectiveC.ObjectiveCMarshal+UnhandledExceptionPropagationHandler"> | |||
| <TypeSignature Language="C#" Value="public delegate method ObjectiveCMarshal.UnhandledExceptionPropagationHandler(Exception exception, RuntimeMethodHandle lastMethod, out IntPtr context);" /> | |||
| <TypeSignature Language="C#" Value="public delegate delegate* unmanaged<IntPtr, void> ObjectiveCMarshal.UnhandledExceptionPropagationHandler(Exception exception, RuntimeMethodHandle lastMethod, out IntPtr context);" /> | |||
There was a problem hiding this comment.
Note for other reviewers: Here's one example of a function pointer in the API.
| @@ -19,7 +19,7 @@ | |||
| <Parameter Name="context" Type="System.IntPtr" RefType="out" /> | |||
| </Parameters> | |||
| <ReturnValue> | |||
| <ReturnType>method</ReturnType> | |||
| <ReturnType>delegate* unmanaged<System.IntPtr, System.Void></ReturnType> | |||
There was a problem hiding this comment.
function pointer as a return type.
Comment on lines
+420
to
+422
| <param name="source">To be added.</param> | ||
| <summary>To be added.</summary> | ||
| <returns>To be added.</returns> |
There was a problem hiding this comment.
@gewarren Changes like this do concern me. Any ideas why this happens?
There was a problem hiding this comment.
Good catch, this is a bug. I've logged https://dev.azure.com/ceapex/Engineering/_workitems/edit/598286.
There was a problem hiding this comment.
I've also logged an issue in this repo to reinstate the comments once the bug is fixed: #7999
gewarren
commented
Apr 26, 2022
| @@ -493,7 +493,7 @@ The precise semantics of batch execution vary across ADO.NET providers, especial | |||
| <Parameter Name="cancellationToken" Type="System.Threading.CancellationToken" /> | |||
| </Parameters> | |||
| <Docs> | |||
| <param name="behavior">One of the enumeration values that specifies options for batch execution and data retrieval.</param> | |||
| <param name="cancellationToken">To be added.</param> | |||
There was a problem hiding this comment.
The System.Data data losses are because the parameter names were accidentally changed in a previous PR. That's being tracked by #7910.
Comment on lines
+420
to
+422
| <param name="source">To be added.</param> | ||
| <summary>To be added.</summary> | ||
| <returns>To be added.</returns> |
There was a problem hiding this comment.
Good catch, this is a bug. I've logged https://dev.azure.com/ceapex/Engineering/_workitems/edit/598286.
Comment on lines
+420
to
+422
| <param name="source">To be added.</param> | ||
| <summary>To be added.</summary> | ||
| <returns>To be added.</returns> |
There was a problem hiding this comment.
I've also logged an issue in this repo to reinstate the comments once the bug is fixed: #7999
BillWagner
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mdoc 5.8.9 adds support for function pointers in C#.