Skip to content

Remove CAS attributes - System.Runtime.Remoting #8009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 3, 2022
Merged

Remove CAS attributes - System.Runtime.Remoting #8009

merged 4 commits into from
May 3, 2022

Conversation

gewarren
Copy link
Contributor

Contributes to dotnet/docs#29143

@ghost
Copy link

ghost commented Apr 28, 2022

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@opbld33

This comment was marked as outdated.

Sign in to view
@gewarren gewarren marked this pull request as ready for review April 28, 2022 23:30
@gewarren gewarren requested a review from a team as a code owner April 28, 2022 23:30
@opbld33
Copy link

opbld33 commented Apr 29, 2022

Docs Build status updates of commit 78e4e54:

✅ Validation status: passed

File Status Preview URL Details
snippets/csharp/System.Runtime.Remoting.Activation/UrlAttribute/Overview/client.cs ✅Succeeded View
snippets/csharp/System.Runtime.Remoting.Channels.Http/HttpChannel/Overview/client.cs ✅Succeeded View
snippets/csharp/System.Runtime.Remoting.Channels.Http/HttpServerChannel/Overview/server.cs ✅Succeeded View
snippets/csharp/System.Runtime.Remoting.Channels.Http/HttpServerChannel/Overview/server2.cs ✅Succeeded View
snippets/csharp/System.Runtime.Remoting.Channels.Ipc/IpcChannel/Overview/Project.csproj ✅Succeeded
snippets/csharp/System.Runtime.Remoting.Channels.Ipc/IpcChannel/Overview/client.cs ✅Succeeded View
snippets/csharp/System.Runtime.Remoting.Channels.Ipc/IpcChannel/Overview/makefile ✅Succeeded
snippets/csharp/System.Runtime.Remoting.Channels.Ipc/IpcChannel/Overview/server.cs ✅Succeeded View
snippets/csharp/System.Runtime.Remoting.Channels.Ipc/IpcChannel/Overview/server2.cs ✅Succeeded View
snippets/csharp/System.Runtime.Remoting.Channels.Ipc/IpcServerChannel/.ctor/Project.csproj ✅Succeeded
snippets/csharp/System.Runtime.Remoting.Channels.Ipc/IpcServerChannel/.ctor/client.cs ✅Succeeded
snippets/csharp/System.Runtime.Remoting.Channels.Ipc/IpcServerChannel/.ctor/makefile ✅Succeeded
snippets/csharp/System.Runtime.Remoting.Channels.Ipc/IpcServerChannel/.ctor/server.cs ✅Succeeded View
snippets/csharp/System.Runtime.Remoting.Channels.Ipc/IpcServerChannel/.ctor/server2.cs ✅Succeeded View
snippets/csharp/System.Runtime.Remoting.Channels.Tcp/TcpChannel/.ctor/Client1.cs ✅Succeeded
snippets/csharp/System.Runtime.Remoting.Channels.Tcp/TcpChannel/.ctor/Project.csproj ✅Succeeded
snippets/csharp/System.Runtime.Remoting.Channels.Tcp/TcpChannel/.ctor/makefile ✅Succeeded
snippets/csharp/System.Runtime.Remoting.Channels.Tcp/TcpChannel/.ctor/makefile1 ✅Succeeded
snippets/csharp/System.Runtime.Remoting.Channels.Tcp/TcpChannel/.ctor/server1.cs ✅Succeeded View
snippets/csharp/System.Runtime.Remoting.Channels.Tcp/TcpChannel/Overview/client.cs ✅Succeeded View
snippets/csharp/System.Runtime.Remoting.Channels.Tcp/TcpChannel/Overview/server.cs ✅Succeeded View
snippets/csharp/System.Runtime.Remoting.Channels.Tcp/TcpClientChannel/.ctor/Project.csproj ✅Succeeded
snippets/csharp/System.Runtime.Remoting.Channels.Tcp/TcpClientChannel/.ctor/client.cs ✅Succeeded View
snippets/csharp/System.Runtime.Remoting.Channels.Tcp/TcpClientChannel/.ctor/client1.cs ✅Succeeded View
snippets/csharp/System.Runtime.Remoting.Channels.Tcp/TcpClientChannel/.ctor/makefile ✅Succeeded

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld31
Copy link

opbld31 commented Apr 29, 2022

Docs Build status updates of commit ededeeb:

✅ Validation status: passed

File Status Preview URL Details
snippets/csharp/System.Runtime.Remoting.Activation/UrlAttribute/Overview/client.cs ✅Succeeded View
snippets/csharp/System.Runtime.Remoting.Channels.Http/HttpChannel/Overview/client.cs ✅Succeeded View
snippets/csharp/System.Runtime.Remoting.Channels.Http/HttpServerChannel/Overview/server.cs ✅Succeeded View
snippets/csharp/System.Runtime.Remoting.Channels.Http/HttpServerChannel/Overview/server2.cs ✅Succeeded View
snippets/csharp/System.Runtime.Remoting.Channels.Ipc/IpcChannel/Overview/Project.csproj ✅Succeeded
snippets/csharp/System.Runtime.Remoting.Channels.Ipc/IpcChannel/Overview/client.cs ✅Succeeded View
snippets/csharp/System.Runtime.Remoting.Channels.Ipc/IpcChannel/Overview/makefile ✅Succeeded
snippets/csharp/System.Runtime.Remoting.Channels.Ipc/IpcChannel/Overview/server.cs ✅Succeeded View
snippets/csharp/System.Runtime.Remoting.Channels.Ipc/IpcChannel/Overview/server2.cs ✅Succeeded View
snippets/csharp/System.Runtime.Remoting.Channels.Ipc/IpcServerChannel/.ctor/Project.csproj ✅Succeeded
snippets/csharp/System.Runtime.Remoting.Channels.Ipc/IpcServerChannel/.ctor/client.cs ✅Succeeded
snippets/csharp/System.Runtime.Remoting.Channels.Ipc/IpcServerChannel/.ctor/makefile ✅Succeeded
snippets/csharp/System.Runtime.Remoting.Channels.Ipc/IpcServerChannel/.ctor/server.cs ✅Succeeded View
snippets/csharp/System.Runtime.Remoting.Channels.Ipc/IpcServerChannel/.ctor/server2.cs ✅Succeeded View
snippets/csharp/System.Runtime.Remoting.Channels.Tcp/TcpChannel/.ctor/Client1.cs ✅Succeeded
snippets/csharp/System.Runtime.Remoting.Channels.Tcp/TcpChannel/.ctor/Project.csproj ✅Succeeded
snippets/csharp/System.Runtime.Remoting.Channels.Tcp/TcpChannel/.ctor/makefile ✅Succeeded
snippets/csharp/System.Runtime.Remoting.Channels.Tcp/TcpChannel/.ctor/makefile1 ✅Succeeded
snippets/csharp/System.Runtime.Remoting.Channels.Tcp/TcpChannel/.ctor/server1.cs ✅Succeeded View
snippets/csharp/System.Runtime.Remoting.Channels.Tcp/TcpChannel/Overview/client.cs ✅Succeeded View
snippets/csharp/System.Runtime.Remoting.Channels.Tcp/TcpChannel/Overview/server.cs ✅Succeeded View
snippets/csharp/System.Runtime.Remoting.Channels.Tcp/TcpClientChannel/.ctor/Project.csproj ✅Succeeded
snippets/csharp/System.Runtime.Remoting.Channels.Tcp/TcpClientChannel/.ctor/client.cs ✅Succeeded View
snippets/csharp/System.Runtime.Remoting.Channels.Tcp/TcpClientChannel/.ctor/client1.cs ✅Succeeded View
snippets/csharp/System.Runtime.Remoting.Channels.Tcp/TcpClientChannel/.ctor/makefile ✅Succeeded

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld34
Copy link

opbld34 commented Apr 29, 2022

Docs Build status updates of commit 8965c07:

✅ Validation status: passed

File Status Preview URL Details
snippets/csharp/System.Runtime.Remoting.Activation/UrlAttribute/Overview/client.cs ✅Succeeded View
snippets/csharp/System.Runtime.Remoting.Channels.Http/HttpChannel/Overview/client.cs ✅Succeeded View
snippets/csharp/System.Runtime.Remoting.Channels.Http/HttpServerChannel/Overview/server.cs ✅Succeeded View
snippets/csharp/System.Runtime.Remoting.Channels.Http/HttpServerChannel/Overview/server2.cs ✅Succeeded View
snippets/csharp/System.Runtime.Remoting.Channels.Ipc/IpcChannel/Overview/Project.csproj ✅Succeeded
snippets/csharp/System.Runtime.Remoting.Channels.Ipc/IpcChannel/Overview/client.cs ✅Succeeded View
snippets/csharp/System.Runtime.Remoting.Channels.Ipc/IpcChannel/Overview/makefile ✅Succeeded
snippets/csharp/System.Runtime.Remoting.Channels.Ipc/IpcChannel/Overview/server.cs ✅Succeeded View
snippets/csharp/System.Runtime.Remoting.Channels.Ipc/IpcChannel/Overview/server2.cs ✅Succeeded View
snippets/csharp/System.Runtime.Remoting.Channels.Ipc/IpcServerChannel/.ctor/Project.csproj ✅Succeeded
snippets/csharp/System.Runtime.Remoting.Channels.Ipc/IpcServerChannel/.ctor/client.cs ✅Succeeded
snippets/csharp/System.Runtime.Remoting.Channels.Ipc/IpcServerChannel/.ctor/makefile ✅Succeeded
snippets/csharp/System.Runtime.Remoting.Channels.Ipc/IpcServerChannel/.ctor/server.cs ✅Succeeded View
snippets/csharp/System.Runtime.Remoting.Channels.Ipc/IpcServerChannel/.ctor/server2.cs ✅Succeeded View
snippets/csharp/System.Runtime.Remoting.Channels.Tcp/TcpChannel/.ctor/Client1.cs ✅Succeeded
snippets/csharp/System.Runtime.Remoting.Channels.Tcp/TcpChannel/.ctor/Project.csproj ✅Succeeded
snippets/csharp/System.Runtime.Remoting.Channels.Tcp/TcpChannel/.ctor/makefile ✅Succeeded
snippets/csharp/System.Runtime.Remoting.Channels.Tcp/TcpChannel/.ctor/makefile1 ✅Succeeded
snippets/csharp/System.Runtime.Remoting.Channels.Tcp/TcpChannel/.ctor/server1.cs ✅Succeeded View
snippets/csharp/System.Runtime.Remoting.Channels.Tcp/TcpChannel/Overview/client.cs ✅Succeeded View
snippets/csharp/System.Runtime.Remoting.Channels.Tcp/TcpChannel/Overview/server.cs ✅Succeeded View
snippets/csharp/System.Runtime.Remoting.Channels.Tcp/TcpClientChannel/.ctor/Project.csproj ✅Succeeded
snippets/csharp/System.Runtime.Remoting.Channels.Tcp/TcpClientChannel/.ctor/client.cs ✅Succeeded View
snippets/csharp/System.Runtime.Remoting.Channels.Tcp/TcpClientChannel/.ctor/client1.cs ✅Succeeded View
snippets/csharp/System.Runtime.Remoting.Channels.Tcp/TcpClientChannel/.ctor/makefile ✅Succeeded

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

BillWagner
BillWagner approved these changes Apr 29, 2022
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

You can :shipit: when ready.

@gewarren gewarren merged commit f037bb4 into dotnet:main May 3, 2022
@gewarren gewarren deleted the cas-three branch May 3, 2022 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gewarren @opbld33 @opbld31 @opbld34 @BillWagner