Skip to content

Update documentation on RuntimeMethodHandle.GetFunctionPointer #8061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 10, 2022

Conversation

jkoritzinsky
Copy link
Member

Update the documentation on RuntimeMethodHandle.GetFunctionPointer now that we have function pointers in C# based on the discussion in dotnet/runtime#65853.

Update the documentation on `RuntimeMethodHandle.GetFunctionPointer` now that we have function pointers in C# based on the discussion in dotnet/runtime#65853.
@jkoritzinsky jkoritzinsky requested a review from a team as a code owner May 10, 2022 18:17
@ghost ghost assigned jkoritzinsky May 10, 2022
@ghost ghost added the area-System.Runtime label May 10, 2022
@AaronRobinsonMSFT
Copy link
Member

/cc @gewarren

@opbld34
Copy link

opbld34 commented May 10, 2022

Docs Build status updates of commit 4dab6b0:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/System/RuntimeMethodHandle.xml ⚠️Warning View Details

xml/System/RuntimeMethodHandle.xml

  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Runtime.InteropServices.UnmanagedCallersOnlyAttribute*'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Runtime.InteropServices.UnmanagedCallersOnlyAttribute*'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I broke it out into two paragraphs - but also fine as-is if you don't like the suggestion.

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@opbld31
Copy link

opbld31 commented May 10, 2022

Docs Build status updates of commit 2aaec14:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/System/RuntimeMethodHandle.xml ⚠️Warning View Details

xml/System/RuntimeMethodHandle.xml

  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Runtime.InteropServices.UnmanagedCallersOnlyAttribute*'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Runtime.InteropServices.UnmanagedCallersOnlyAttribute*'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@opbld33
Copy link

opbld33 commented May 10, 2022

Docs Build status updates of commit 0ee4430:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/System/RuntimeMethodHandle.xml ⚠️Warning View Details

xml/System/RuntimeMethodHandle.xml

  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Runtime.InteropServices.UnmanagedCallersOnlyAttribute*'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Runtime.InteropServices.UnmanagedCallersOnlyAttribute*'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the xrefs.

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@opbld34
Copy link

opbld34 commented May 10, 2022

Docs Build status updates of commit 663d97e:

✅ Validation status: passed

File Status Preview URL Details
xml/System/RuntimeMethodHandle.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@jkoritzinsky jkoritzinsky merged commit 6435f0a into main May 10, 2022
@jkoritzinsky jkoritzinsky deleted the jekoritz/getfunctionpointer-update branch May 10, 2022 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants