Skip to content

Add alert about CAS deprecation #8105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 7, 2022
Merged

Add alert about CAS deprecation #8105

merged 4 commits into from
Jun 7, 2022

Conversation

gewarren
Copy link
Contributor

Contributes to dotnet/docs#29152.

This PR includes all the APIs that were obsoleted with SYSLIB0003. We still need to add the alert to APIs that weren't ported to .NET Core.

@ghost ghost assigned gewarren May 26, 2022
@ghost ghost added the area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable. label May 26, 2022
@opbld34
Copy link

opbld34 commented May 26, 2022

Docs Build status updates of commit 2a2a221:

✅ Validation status: passed

File Status Preview URL Details
includes/cas-deprecated.md ✅Succeeded View
xml/System.Configuration/ConfigurationPermission.xml ✅Succeeded View
xml/System.Configuration/ConfigurationPermissionAttribute.xml ✅Succeeded View
xml/System.Data.Common/DBDataPermission.xml ✅Succeeded View
xml/System.Data.Common/DBDataPermissionAttribute.xml ✅Succeeded View
xml/System.Data.Odbc/OdbcPermission.xml ✅Succeeded View
xml/System.Data.Odbc/OdbcPermissionAttribute.xml ✅Succeeded View
xml/System.Data.OleDb/OleDbPermission.xml ✅Succeeded View
xml/System.Data.OleDb/OleDbPermissionAttribute.xml ✅Succeeded View
xml/System.Data.OracleClient/OraclePermission.xml ✅Succeeded View
xml/System.Data.OracleClient/OraclePermissionAttribute.xml ✅Succeeded View
xml/System.Data.SqlClient/SqlClientPermission.xml ✅Succeeded View
xml/System.Data.SqlClient/SqlClientPermissionAttribute.xml ✅Succeeded View
xml/System.Diagnostics/EventLogPermission.xml ✅Succeeded View
xml/System.Diagnostics/EventLogPermissionAttribute.xml ✅Succeeded View
xml/System.Diagnostics/PerformanceCounterPermission.xml ✅Succeeded View
xml/System.Diagnostics/PerformanceCounterPermissionAttribute.xml ✅Succeeded View
xml/System.DirectoryServices/DirectoryServicesPermission.xml ✅Succeeded View
xml/System.DirectoryServices/DirectoryServicesPermissionAttribute.xml ✅Succeeded View
xml/System.Drawing.Printing/PrintingPermission.xml ✅Succeeded View
xml/System.Drawing.Printing/PrintingPermissionAttribute.xml ✅Succeeded View
xml/System.Net.Mail/SmtpPermission.xml ✅Succeeded View
xml/System.Net.Mail/SmtpPermissionAttribute.xml ✅Succeeded View
xml/System.Net.NetworkInformation/NetworkInformationPermission.xml ✅Succeeded View
xml/System.Net.NetworkInformation/NetworkInformationPermissionAttribute.xml ✅Succeeded View

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one comment.

Comment on lines 86 to 87
> [!IMPORTANT]
> Partially trusted code is no longer supported. This attribute has no effect in .NET Core.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This alert and similar instances of "no longer supported" appear in a lot of places, but they seem to be redundant after the new include and could be deleted.

@gewarren gewarren enabled auto-merge June 7, 2022 18:43
@opbld34
Copy link

opbld34 commented Jun 7, 2022

Docs Build status updates of commit 7f4e574:

✅ Validation status: passed

File Status Preview URL Details
includes/cas-deprecated.md ✅Succeeded View
xml/System.Configuration/ConfigurationPermission.xml ✅Succeeded View
xml/System.Configuration/ConfigurationPermissionAttribute.xml ✅Succeeded View
xml/System.Data.Common/DBDataPermission.xml ✅Succeeded View
xml/System.Data.Common/DBDataPermissionAttribute.xml ✅Succeeded View
xml/System.Data.Odbc/OdbcPermission.xml ✅Succeeded View
xml/System.Data.Odbc/OdbcPermissionAttribute.xml ✅Succeeded View
xml/System.Data.OleDb/OleDbPermission.xml ✅Succeeded View
xml/System.Data.OleDb/OleDbPermissionAttribute.xml ✅Succeeded View
xml/System.Data.OracleClient/OraclePermission.xml ✅Succeeded View
xml/System.Data.OracleClient/OraclePermissionAttribute.xml ✅Succeeded View
xml/System.Data.SqlClient/SqlClientPermission.xml ✅Succeeded View
xml/System.Data.SqlClient/SqlClientPermissionAttribute.xml ✅Succeeded View
xml/System.Diagnostics/EventLogPermission.xml ✅Succeeded View
xml/System.Diagnostics/EventLogPermissionAttribute.xml ✅Succeeded View
xml/System.Diagnostics/PerformanceCounterPermission.xml ✅Succeeded View
xml/System.Diagnostics/PerformanceCounterPermissionAttribute.xml ✅Succeeded View
xml/System.DirectoryServices/DirectoryServicesPermission.xml ✅Succeeded View
xml/System.DirectoryServices/DirectoryServicesPermissionAttribute.xml ✅Succeeded View
xml/System.Drawing.Printing/PrintingPermission.xml ✅Succeeded View
xml/System.Drawing.Printing/PrintingPermissionAttribute.xml ✅Succeeded View
xml/System.Net.Mail/SmtpPermission.xml ✅Succeeded View
xml/System.Net.Mail/SmtpPermissionAttribute.xml ✅Succeeded View
xml/System.Net.NetworkInformation/NetworkInformationPermission.xml ✅Succeeded View
xml/System.Net.NetworkInformation/NetworkInformationPermissionAttribute.xml ✅Succeeded View

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@gewarren gewarren merged commit 86a2727 into dotnet:main Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants