Skip to content

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented May 28, 2022

Contributes to #1364.

  • Adds missing words
  • Adds spaces between backticks and angle brackets where needed

This is mostly just whitespace changes, so I recommend hiding whitespace changes in diff. (Double whitespace is how I found missing words, which is why I went to the trouble of cleaning it up.)

@ghost ghost assigned gewarren May 28, 2022
@ghost ghost added the area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable. label May 28, 2022
@AaronRobinsonMSFT
Copy link
Member

InteropServices and related doc LGTM.

@opbld31

This comment was marked as outdated.

@opbld34
Copy link

opbld34 commented May 28, 2022

Docs Build status updates of commit 713e7ef:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/System.Diagnostics.SymbolStore/SymMethod.xml ⚠️Warning View Details
xml/Microsoft.Extensions.DependencyInjection/HttpClientBuilderExtensions.xml ✅Succeeded View
xml/Microsoft.VisualBasic.Compatibility.VB6/FixedLengthString.xml ✅Succeeded View
xml/Microsoft.VisualBasic/Interaction.xml ✅Succeeded View
xml/Microsoft.Win32/FileDialogCustomPlaces.xml ✅Succeeded View
xml/System.Activities.Validation/ValidationSettings.xml ✅Succeeded View
xml/System.Activities/NativeActivityContext.xml ✅Succeeded View
xml/System.CodeDom.Compiler/CompilerParameters.xml ✅Succeeded View
xml/System.Collections.Generic/HashSet`1.xml ✅Succeeded View
xml/System.Collections.Generic/List`1.xml ✅Succeeded View
xml/System.Collections.Immutable/IImmutableList`1.xml ✅Succeeded View
xml/System.Collections.Immutable/ImmutableList`1.xml ✅Succeeded View
xml/System.Collections.Immutable/ImmutableSortedSet`1.xml ✅Succeeded View
xml/System.ComponentModel.Design/DesignerActionList.xml ✅Succeeded View
xml/System.ComponentModel.Design/DesignerActionUIService.xml ✅Succeeded View
xml/System.ComponentModel/MaskedTextResultHint.xml ✅Succeeded View
xml/System.ComponentModel/PropertyFilterOptions.xml ✅Succeeded View
xml/System.Configuration/Configuration.xml ✅Succeeded View
xml/System.Configuration/ConnectionStringsSection.xml ✅Succeeded View
xml/System.Configuration/OverrideMode.xml ✅Succeeded View
xml/System.Data.Common.CommandTrees/DbLimitExpression.xml ✅Succeeded View
xml/System.Data.Metadata.Edm/GlobalItem.xml ✅Succeeded View
xml/System.Data.Metadata.Edm/StoreGeneratedPattern.xml ✅Succeeded View
xml/System.Data.Objects.DataClasses/EntityCollection`1.xml ✅Succeeded View
xml/System.Data.Objects/ObjectQuery`1.xml ✅Succeeded View

This comment lists only the first 25 files in the pull request.

xml/System.Diagnostics.SymbolStore/SymMethod.xml

  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Diagnostics.SymbolStore.Private.ISymUnmanagedMethod'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I skimmed this one. It LGTM @gewarren

@gewarren
Copy link
Contributor Author

Thanks @AaronRobinsonMSFT and @BillWagner.

@gewarren gewarren merged commit 2e87782 into dotnet:main May 31, 2022
@gewarren gewarren deleted the whitespace-cleanup branch May 31, 2022 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants