Skip to content

Conversation

MSDN-WhiteKnight
Copy link
Contributor

Update IDisposable inheritance examples to use FileStream instead of IntPtr.Zero safe handle. Using IntPtr.Zero handle is invalid and causes issues in Linux, where zero handle refers to stdin stream. There are some unrelated changes in VB, they are needed to make project compile, because there were name collisions.

Related to: dotnet/runtime#64305

@MSDN-WhiteKnight MSDN-WhiteKnight requested a review from a team as a code owner May 30, 2022 05:44
@ghost ghost added the area-System.Runtime label May 30, 2022
@opbld32
Copy link

opbld32 commented May 30, 2022

Docs Build status updates of commit 490ac6f:

✅ Validation status: passed

File Status Preview URL Details
snippets/csharp/System/IDisposable/Overview/base1.cs ✅Succeeded View
snippets/csharp/System/IDisposable/Overview/derived1.cs ✅Succeeded View
snippets/fsharp/System/IDisposable/Overview/base1.fs ✅Succeeded View
snippets/fsharp/System/IDisposable/Overview/derived1.fs ✅Succeeded View
snippets/visualbasic/VS_Snippets_CLR_System/system.idisposable/vb/IDisposableSnippets.vbproj ✅Succeeded
snippets/visualbasic/VS_Snippets_CLR_System/system.idisposable/vb/base1.vb ✅Succeeded View
snippets/visualbasic/VS_Snippets_CLR_System/system.idisposable/vb/calling2.vb ✅Succeeded View
snippets/visualbasic/VS_Snippets_CLR_System/system.idisposable/vb/derived1.vb ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld34
Copy link

opbld34 commented May 30, 2022

Docs Build status updates of commit 67e6cca:

✅ Validation status: passed

File Status Preview URL Details
snippets/csharp/System/IDisposable/Overview/base1.cs ✅Succeeded View
snippets/csharp/System/IDisposable/Overview/derived1.cs ✅Succeeded View
snippets/fsharp/System/IDisposable/Overview/base1.fs ✅Succeeded View
snippets/fsharp/System/IDisposable/Overview/derived1.fs ✅Succeeded View
snippets/visualbasic/VS_Snippets_CLR_System/system.idisposable/vb/IDisposableSnippets.vbproj ✅Succeeded
snippets/visualbasic/VS_Snippets_CLR_System/system.idisposable/vb/base1.vb ✅Succeeded View
snippets/visualbasic/VS_Snippets_CLR_System/system.idisposable/vb/calling2.vb ✅Succeeded View
snippets/visualbasic/VS_Snippets_CLR_System/system.idisposable/vb/derived1.vb ✅Succeeded View
snippets/visualbasic/VS_Snippets_CLR_System/system.idisposable/vb/derived2.vb ✅Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld34
Copy link

opbld34 commented May 30, 2022

Docs Build status updates of commit 67e6cca:

✅ Validation status: passed

File Status Preview URL Details
snippets/csharp/System/IDisposable/Overview/base1.cs ✅Succeeded View
snippets/csharp/System/IDisposable/Overview/derived1.cs ✅Succeeded View
snippets/fsharp/System/IDisposable/Overview/base1.fs ✅Succeeded View
snippets/fsharp/System/IDisposable/Overview/derived1.fs ✅Succeeded View
snippets/visualbasic/VS_Snippets_CLR_System/system.idisposable/vb/IDisposableSnippets.vbproj ✅Succeeded
snippets/visualbasic/VS_Snippets_CLR_System/system.idisposable/vb/base1.vb ✅Succeeded View
snippets/visualbasic/VS_Snippets_CLR_System/system.idisposable/vb/calling2.vb ✅Succeeded View
snippets/visualbasic/VS_Snippets_CLR_System/system.idisposable/vb/derived1.vb ✅Succeeded View
snippets/visualbasic/VS_Snippets_CLR_System/system.idisposable/vb/derived2.vb ✅Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MSDN-WhiteKnight This is great, and I'll :shipit: now.

@BillWagner BillWagner merged commit 12360a3 into dotnet:main May 31, 2022
@MSDN-WhiteKnight MSDN-WhiteKnight deleted the patch-2 branch June 1, 2022 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants