Snippet2 missing method, generateXMLString #8118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
//<Snippet2> is referenced by a documentation page for XmlDocument (see below for URLs). When the code copied from the documentation is pasted into a Windows Forms app and the namespaces added, the code does not compile. The compilation error is caused because one method is missing, generateXMLString. There is a copy button on documentation page which copies <Snippet2>. I moved generateXMLString from the top of xmlhelpermethods.cs where it is not used into //<Snippet2> so it will be included in the example code for the XmlDocument class. //<Snippet2> is referenced by https://docs.microsoft.com/en-us/dotnet/api/system.xml.xmldocument?view=net-6.0 https://github.com/dotnet/dotnet-api-docs/blob/main/xml/System.Xml/XmlDocument.xml Here is where snippet 2 is referenced [!code-csharp[XMLProcessingApp#2](~/snippets/csharp/System.Xml/XmlDocument/Overview/xmlhelpermethods.cs#2)]
|
|
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Docs Build status updates of commit 38c8e03: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
BillWagner
approved these changes
May 31, 2022
now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
// is referenced by a documentation page for XmlDocument (see below for URLs). When the code copied from the documentation is pasted into a Windows Forms app and the namespaces added, the code does not compile. The compilation error is caused because one method is missing, generateXMLString. There is a copy button on documentation page which copies . I moved generateXMLString from the top of xmlhelpermethods.cs where it is not used into // so it will be included in the example code for the XmlDocument class.
// is referenced by
https://docs.microsoft.com/en-us/dotnet/api/system.xml.xmldocument?view=net-6.0
https://github.com/dotnet/dotnet-api-docs/blob/main/xml/System.Xml/XmlDocument.xml
Here is where snippet 2 is referenced
[!code-csharpXMLProcessingApp#2]
Summary
Describe your changes here.
Fixes #Issue_Number (if available)