CI Update - .NET 7 Preview 4 assemblies #8122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build.Reason:Manual by Genevieve Warren Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=296273&view=results source_repo.branch:net7-pre4 source_repo.url:https://apidrop.visualstudio.com/_git/binaries
gewarren
requested review from
RussKie,
merriemcgaw,
a team,
AaronRobinsonMSFT,
jkoritzinsky,
ajcvickers,
David-Engel and
JRahnama
as code owners
ghost
added
the
area-Meta
This comment was marked as outdated.
This comment was marked as outdated.
Build.Reason:Manual by Genevieve Warren Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=296367&view=results source_repo.branch:net7-pre4 source_repo.url:https://apidrop.visualstudio.com/_git/binaries
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
gewarren
commented
Jun 2, 2022
| <typeparam name="TSelf">The type that implements this interface.</typeparam> | ||
| <typeparam name="TResult">The type that contains the additive identify of <typeparamref name="TSelf" />.</typeparam> | ||
| <summary>Defines a mechanism for getting the additive identity of a given type.</summary> | ||
| <typeparam name="TSelf">To be added.</typeparam> |
There was a problem hiding this comment.
I can take care of this with the porting tool.
| </ReturnValue> | ||
| <Docs> | ||
| <summary>Gets the additive identity of the current type.</summary> | ||
| <summary>To be added.</summary> |
| <typeparam name="TOther">The type that will is used in the operation with <typeparamref name="TSelf" />.</typeparam> | ||
| <typeparam name="TResult">The type that contains the result of <typeparamref name="TSelf" /> op <typeparamref name="TOther" />.</typeparam> | ||
| <summary>Defines a mechanism for performing bitwise operations over two values.</summary> | ||
| <typeparam name="TSelf">To be added.</typeparam> |
There was a problem hiding this comment.
Comment loss. Looks like we'll have to manually port the doc comments for the renamed interfaces.
| <Docs> | ||
| <typeparam name="TSelf">The type that implements this interface.</typeparam> | ||
| <summary>Defines a mechanism for parsing a string to a value.</summary> | ||
| <typeparam name="TSelf">To be added.</typeparam> |
| <Docs> | ||
| <typeparam name="TSelf">The type that implements this interface.</typeparam> | ||
| <summary>Defines a mechanism for parsing a span of characters to a value.</summary> | ||
| <typeparam name="TSelf">To be added.</typeparam> |
carlossanlop
approved these changes
Jun 2, 2022
There was a problem hiding this comment.
LGTM @gewarren . I'll make sure the porting tool addresses the renamed API documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build.Reason:Manual by Genevieve Warren
Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=296273&view=results
source_repo.branch:net7-pre4
source_repo.url:https://apidrop.visualstudio.com/_git/binaries