Skip to content

Conversation

elgonzo
Copy link
Contributor

@elgonzo elgonzo commented Jan 9, 2023

Summary

Removes the sentence

The Position property does not keep track of the number of bytes from the stream that have been consumed, skipped, or both.

from the remark sections of

  • Syste.IO.Stream.Position
  • System.Data.OracleClient.OracleLob.Position
  • System.Data.OracleClient.OracleBFile.Position

Fixes #8772

@elgonzo elgonzo requested a review from a team as a code owner January 9, 2023 16:18
@ghost ghost added community-contribution Indicates that the PR has been added by a community member area-System.IO labels Jan 9, 2023
@ghost
Copy link

ghost commented Jan 9, 2023

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

Summary

Removes the sentence

The Position property does not keep track of the number of bytes from the stream that have been consumed, skipped, or both.

from the Stream.Property remarks section.

Fixes #8772

Author: elgonzo
Assignees: -
Labels:

area-System.IO, community-contribution

Milestone: -

@learn-build-service-prod
Copy link

Learn Build status updates of commit 3268928:

✅ Validation status: passed

File Status Preview URL Details
xml/System.IO/Stream.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@learn-build-service-prod
Copy link

Learn Build status updates of commit 3370587:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Data.OracleClient/OracleBFile.xml ✅Succeeded View
xml/System.Data.OracleClient/OracleLob.xml ✅Succeeded View
xml/System.IO/Stream.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your contribution @elgonzo !

@adamsitnik adamsitnik merged commit 4965806 into dotnet:main Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.IO community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System.IO.Stream.Position remarks section has puzzling sentence
2 participants