UserPrincipal.GetAuthorizationGroups(): Clarify null return scenario #8788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this only returns security groups, it will still return null if the user is a member of distribution groups, but not security groups. So it's not entirely accurate to say that it will return "null if the user does not belong to *any* groups".
ghost
added
community-contribution
gabeluci
changed the title
|
Learn Build status updates of commit 5e24f60: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
buyaa-n
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
UserPrincipal.GetAuthorizationGroups()only returns security groups, it will still return null if the user is a member of distribution groups, but not security groups. So it's not entirely accurate to say that it will return "null if the user does not belong to any groups".I propose that sentence is changed to "null if the user does not belong to any security groups."