Skip to content

Fix: Parameter name changed for better readibility #8839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2023
Merged

Fix: Parameter name changed for better readibility #8839

merged 1 commit into from
Feb 13, 2023

Conversation

ahmedtahami
Copy link
Contributor

Summary

I have renamed the parameter FileName to DirectoryName in the Directory.GetAccessControl Method.

Fixes #8831

@ahmedtahami
Fix: Parameter name changed for better readibility
9eecc25 
 Rename Parameter FileName in Directory.GetAccessControl Method Examples Documentation dotnet#8831
@ahmedtahami ahmedtahami requested a review from a team as a code owner February 13, 2023 01:06
@ghost ghost added community-contribution Indicates that the PR has been added by a community member area-System.IO labels Feb 13, 2023
@ghost
Copy link

ghost commented Feb 13, 2023

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

Summary

I have renamed the parameter FileName to DirectoryName in the Directory.GetAccessControl Method.

Fixes #8831

Author: ahmedtahami
Assignees: -
Labels:

area-System.IO, community-contribution
Milestone: -

@learn-build-service-prod
Copy link

Learn Build status updates of commit 9eecc25:

✅ Validation status: passed

File Status Preview URL Details
snippets/csharp/System.IO/Directory/GetAccessControl/sample.cs ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

adamsitnik
adamsitnik approved these changes Feb 13, 2023
View reviewed changes
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your contribution @ahmedtahami !

@adamsitnik adamsitnik merged commit b3f3c48 into dotnet:main Feb 13, 2023
@ahmedtahami
Copy link
Contributor Author

LGTM, thank you for your contribution @ahmedtahami !

Thanks, @adamsitnik, Looking forward to contributing more!
This was my first ever open-source contribution.

@ahmedtahami ahmedtahami deleted the patch-1 branch February 13, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamsitnik adamsitnik adamsitnik approved these changes

Assignees
No one assigned
Labels
area-System.IO community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename Parameter FileName in Directory.GetAccessControl Method Examples Documentation
2 participants
@ahmedtahami @adamsitnik